From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dmitry Dolgov <9erthalion6@gmail.com>
cc: Peter Smith <smithpb2250@gmail.com>, vignesh C <vignesh21@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Nathan Bossart <nathandbossart@gmail.com>,
        "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
        David Geier <geidav.pg@gmail.com>, Sergei Kornilov <sk@zsrv.org>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Marcos Pegoraro <marcos@f10.com.br>,
        Robert Haas <robertmhaas@gmail.com>, Zhihong Yu <zyu@yugabyte.com>,
        David Steele <david@pgmasters.net>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Pavel Trukhanov <pavel.trukhanov@gmail.com>
Subject: Re: pg_stat_statements and "IN" conditions
In-reply-to: <20240122161123.tzau4pe6wp7h5vh2@erthalion.local>
References: <ZSj6pOwUCM-Mnh__@paquier.xyz>
 <20231013133519.yf26oncodrvemfjw@ddolgov.remote.csb>
 <20231017081541.octf6qghtjllwtvj@erthalion.local>
 <ZTmuCtymIS3n3fP_@paquier.xyz>
 <20231027150244.jmdvn23l4rpx6hha@erthalion.local>
 <20231031090307.qkpmcgq53bzcoz7c@erthalion.local>
 <CALDaNm0Oov2Xbt8PLGOhFTLF7_uEWu6_pz2xHeEtQQiUx6nRiw@mail.gmail.com>
 <20240108161020.pltnhlbtc7x32tj4@erthalion.local>
 <20240113140538.ifmkd7y2kvfnsj3w@erthalion.local>
 <CAHut+PuXZsPPJyUnYY7RHSM0vspM0z42KfsTvOetJNkuuDGZSQ@mail.gmail.com>
 <20240122161123.tzau4pe6wp7h5vh2@erthalion.local>
Comments: In-reply-to Dmitry Dolgov <9erthalion6@gmail.com>
	message dated "Mon, 22 Jan 2024 17:11:23 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3746171.1705941322.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 22 Jan 2024 11:35:22 -0500
Message-ID: <3746172.1705941322@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3746172.1705941322%40sss.pgh.pa.us>
Precedence: bulk

Dmitry Dolgov <9erthalion6@gmail.com> writes:
>> On Mon, Jan 22, 2024 at 05:33:26PM +1100, Peter Smith wrote:
>> Hi, This patch has a CF status of "Needs Review" [1], but it seems
>> there was a CFbot test failure last time it was run [2]. Please have a
>> look and post an updated version if necessary.
>> =

>> =3D=3D=3D=3D=3D=3D
>> [1] https://commitfest.postgresql.org/46/2837/
>> [2] https://cirrus-ci.com/task/6688578378399744

> It's the same failing pipeline Vignesh C was talking above. I've fixed
> the issue in the latest patch version, but looks like it wasn't picked
> up yet (from what I understand, the latest build for this CF is 8 weeks
> old).

Please notice that at the moment, it's not being tested at all because
of a patch-apply failure -- that's what the little triangular symbol
means.  The rest of the display concerns the test results from the
last successfully-applied patch version.  (Perhaps that isn't a
particularly great UI design.)

If you click on the triangle you find out

=3D=3D Applying patches on top of PostgreSQL commit ID b0f0a9432d0b6f53634=
a96715f2666f6d4ea25a1 =3D=3D=3D
=3D=3D=3D applying patch ./v17-0001-Prevent-jumbling-of-every-element-in-A=
rrayExpr.patch
patching file contrib/pg_stat_statements/Makefile
Hunk #1 FAILED at 19.
1 out of 1 hunk FAILED -- saving rejects to file contrib/pg_stat_statement=
s/Makefile.rej
patching file contrib/pg_stat_statements/expected/merging.out
patching file contrib/pg_stat_statements/meson.build
...

			regards, tom lane