Feedback-ID: ie0a040ee:Fastmail
Message-ID: <3762a2e0-d3be-40e7-83d2-52dc3e1a21b2@eisentraut.org>
Date: Mon, 4 May 2026 16:46:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Bug][patch]: After dropping the last label from a property graph
 element, invoking pg_get_propgraphdef() triggers an assertion failure
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAHg+QDeP=mTHTV48R23zKMy1SBmCKZ_L7-z5zKnYyw+K0x-gCg@mail.gmail.com>
 <CAExHW5tsOK7ja2dMykD_qQSLwsuZxCTHx_jFyx-7-O+9WRBDXQ@mail.gmail.com>
 <CAHg+QDcXxmeiuySsyR5K=8Wk9Pq2sZ_4HNb6EMonN=yjLz_fyw@mail.gmail.com>
 <CAExHW5t2YtTMnK7qbvL++pBet-5B8bzgU+8wMcC5aqZwBH0C9w@mail.gmail.com>
 <CAHg+QDdAoW2cU2Wa-yKQs2awHxc19mkHGaAvDUZN=PZUDVsD=A@mail.gmail.com>
 <CAExHW5uThebnwqyWHrsF2Z+no-fT8VrM0Yj+RU7YWrYzdavUZg@mail.gmail.com>
 <CAExHW5tiOi=8Oq5Tza8gNz_jYmbWv+vb+p2fARUbfGnm-m7-9Q@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAExHW5tiOi=8Oq5Tza8gNz_jYmbWv+vb+p2fARUbfGnm-m7-9Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3762a2e0-d3be-40e7-83d2-52dc3e1a21b2%40eisentraut.org>
Precedence: bulk

On 28.04.26 17:02, Ashutosh Bapat wrote:
> We are looking up element label catalogs twice in this patch - first
> to find the label to be dropped and then to find the number of labels
> associated with the given element. I combined these two into a single
> while loop.

That looks okay, but I think the names of the local variables are now a 
bit off.  I would expect elrel and elscan to refer to 
pg_propgraph_element, not pg_propgraph_element_label.  Maybe use 
ellabelrel etc.

Also, I think this code needs to think a bit about locking to handle the 
situation where more than one DROP LABEL operation happens concurrently.