From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Regression tests vs existing users in an installation
In-reply-to: <499f2909-d6e4-4f50-d88a-0e3dc9530f4e@2ndquadrant.com>
References: <20160716035456.GA181422@alvherre.pgsql>
 <25245.1468683514@sss.pgh.pa.us>
 <CA+TgmoZf-TodYQJz91bLm8WLsEefNhdJJfM1wn+AnYehadDwoA@mail.gmail.com>
 <23690.1468854782@sss.pgh.pa.us>
 <CA+Tgmobttcs_WcZivJ5dVmpS1MoKgDKF4d-dVRvWO4JhBDvFRA@mail.gmail.com>
 <1382.1561520002@sss.pgh.pa.us>
 <CA+TgmobN1d2BFL6Wa0YgrVLiVYhrB9TMWygHKDdAaEJtHprBHw@mail.gmail.com>
 <27282.1561668606@sss.pgh.pa.us> <20190628154110.GM2480@tamriel.snowman.net>
 <25897.1561828908@sss.pgh.pa.us>
 <499f2909-d6e4-4f50-d88a-0e3dc9530f4e@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Tue, 26 Nov 2019 22:10:15 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3769.1574807536.1@sss.pgh.pa.us>
Date: Tue, 26 Nov 2019 17:32:16 -0500
Message-ID: <3770.1574807536@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I found this directory, and it seems like a good place to add some more 
> tests (other thread), but I'm puzzled why it's hidden under modules/, 
> since it's not, well, a module.  Why is it not in src/test/?

Doing it like this allowed it to be picked up automatically by the
buildfarm script.  If we'd put it in a new src/test directory, the
buildfarm script would have had to be taught about that, and we'd
have no coverage until owners updated their machines.  So it
seemed expedient to do it like this.

			regards, tom lane