From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
cc: Peter Smith <smithpb2250@gmail.com>, Michael Paquier <michael@paquier.xyz>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Peter Eisentraut <peter@eisentraut.org>,
        Daniel Gustafsson <daniel@yesql.se>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: GUC names in messages
In-reply-to: <db3e4290ced77111c17e7a2adfb1d660734f5f78.camel@cybertec.at>
References: <ZWAUV4fdjFw5nWvj@paquier.xyz> <202311240953.6linnh7oxsdn@alvherre.pgsql> <CAHut+Pu91ik+U1ffV4e9a7R_aHFdqNrF8mBJ4FYtPfo8oDL6Yw@mail.gmail.com> <ZWP0VoXV8QYBGwhC@paquier.xyz> <CAHut+Pvy=7Sk8Jz9YzU+0Brp1Ki=0DNz6eRgosDCfAAaT+vWHQ@mail.gmail.com> <db3e4290ced77111c17e7a2adfb1d660734f5f78.camel@cybertec.at>
Comments: In-reply-to Laurenz Albe <laurenz.albe@cybertec.at>
	message dated "Mon, 27 Nov 2023 07:31:50 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3772064.1701066944.1@sss.pgh.pa.us>
Date: Mon, 27 Nov 2023 01:35:44 -0500
Message-ID: <3772065.1701066944@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3772065.1701066944%40sss.pgh.pa.us>
Precedence: bulk

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Mon, 2023-11-27 at 13:41 +1100, Peter Smith wrote:
>> In the documentation and in the guc_tables.c they are all described in
>> MixedCase (e.g. "DateStyle" instead of "datestyle"), so I felt the
>> messages should use the same case the documentation, which is why I
>> changed all the ones you are referring to.

> I agree with that decision; we should use mixed case for these parameters.
> Otherwise we might get complaints that the following query does not return
> any results:
>   SELECT * FROM pg_settings WHERE name = 'timezone';

Yeah.  Like Michael upthread, I've wondered occasionally about changing
these names to all-lower-case.  It'd surely be nicer if we'd done it
like that to begin with.  But I can't convince myself that the ensuing
user pain would be justified.

			regards, tom lane