From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
        Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: Remove the refint contrib module (for v20)
In-reply-to: 
 <CAJTYsWUHq8Ohc6-N-xamOPYz-q3qUYMtwQX-1=Zi=5N1Q_GSEQ@mail.gmail.com>
References: 
 <CAJTYsWUHq8Ohc6-N-xamOPYz-q3qUYMtwQX-1=Zi=5N1Q_GSEQ@mail.gmail.com>
Comments: In-reply-to Ayush Tiwari <ayushtiwari.slg01@gmail.com>
	message dated "Sat, 06 Jun 2026 00:57:56 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3788237.1780697387.1@sss.pgh.pa.us>
Date: Fri, 05 Jun 2026 18:09:47 -0400
Message-ID: <3788238.1780697387@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3788238.1780697387%40sss.pgh.pa.us>
Precedence: bulk

Ayush Tiwari <ayushtiwari.slg01@gmail.com> writes:
> Thoughts?  Does this look like the right approach, or is there a
> reason to keep refint around?

The only reason for refint to exist anymore is as example code,
but I think it's well short of our current standards, so it
really would need more work if we want to keep it.  Some things
I'd want to see worked on if we keep it:

* The comments are not great

* Error handling is haphazard, eg inconsistent mix of elog and ereport

* After the cache-ectomy, it's hardly clear why it's still using
SPI_prepare rather than just SPI_execute_with_args

I doubt that anyone really wants to put in that work, so I'm
good with just removing it.

			regards, tom lane