From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>,
        Peter Smith <smithpb2250@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
In-reply-to: <Z5MxuDQBr_S8YNwW@paquier.xyz>
References: <87jzc46d8u.fsf@wibble.ilmari.org> <5f41d6c6-1cbb-494d-a5c4-3c449fc4e9ad@dunslane.net> <105f432a-6b0b-42d4-9061-65d263279be7@app.fastmail.com> <CAHut+PuD0aQfjAN0q_7FpdNdSEdrhONpTsb0tQi5ZEtZHj6bKg@mail.gmail.com> <87ldv542fk.fsf@wibble.ilmari.org> <CAHut+PvKrQXY7kM8ct=HC9xYPC6yhdJWnvCgijtgxmO-mus8uQ@mail.gmail.com> <Z49PYgXnbyU6IiEe@paquier.xyz> <87frlc45gg.fsf@wibble.ilmari.org> <Z5CHN6WajoZP6Rqz@paquier.xyz> <878qr146ra.fsf@wibble.ilmari.org> <Z5MxuDQBr_S8YNwW@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 24 Jan 2025 15:22:48 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <379084.1737734611.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 24 Jan 2025 11:03:31 -0500
Message-ID: <379085.1737734611@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/379085.1737734611%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jan 23, 2025 at 08:25:45PM +0000, Dagfinn Ilmari Manns=C3=A5ker =
wrote:
>> Here's a patch for that.

> Thanks.  I had a bit of time today and applied it.

BF member drongo doesn't like the new test for amcheck.
Looks like it has to do with SSPI authentication producing
a different error than expected:

stderr:
#   Failed test 'checking with a non-existent user stderr /(?^:role "no_su=
ch_user" does not exist)/'
#   at C:/prog/bf/root/HEAD/pgsql/src/bin/pg_amcheck/t/002_nonesuch.pl lin=
e 86.
#                   'pg_amcheck: error: connection to server at "127.0.0.1=
", port 19928 failed: FATAL:  SSPI authentication failed for user "no_such=
_user"
# '
#     doesn't match '(?^:role "no_such_user" does not exist)'
# Looks like you failed 1 test of 107.

You might be able to work around this with auth_extra,
a la 1e3f461e8 and other past fixes.

			regards, tom lane