public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Matthias van de Meent <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Subject: Re: BufmgrCommit no-op since 2008, remaining uses?
Date: Wed, 29 Mar 2023 08:12:05 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com>
References: <CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com>

Matthias van de Meent <[email protected]> writes:
> BufmgrCommit does exactly nothing; it is an empty function and has
> been since commit 33960006 in late 2008 when it stopped calling
> smgrcommit().
> All two usages of the function (in our code base) seem to be in
> xact.c. Are we maintaining it for potential future use, or can the
> function be removed?

Seems reasonable.  Even if bufmgr grew a new need to be called
during commit, it would quite possibly need to be called from
a different spot; so I doubt that the function is useful even
as a placeholder.

			regards, tom lane

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: BufmgrCommit no-op since 2008, remaining uses?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox