Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1soNuI-00ApXs-Gj for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Sep 2024 14:01:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1soNuG-000q7m-Tl for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Sep 2024 14:01:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1soNuG-000q7e-Ja for pgsql-hackers@lists.postgresql.org; Wed, 11 Sep 2024 14:01:16 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1soNuC-000eiM-GN for pgsql-hackers@lists.postgresql.org; Wed, 11 Sep 2024 14:01:15 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 48BE19kS3810913; Wed, 11 Sep 2024 10:01:09 -0400 From: Tom Lane To: Aleksander Alekseev cc: pgsql-hackers@lists.postgresql.org, Maciek Sakrejda , Hunaid Sohail Subject: Re: Test improvements and minor code fixes for formatting.c. In-reply-to: References: <2956175.1725831136@sss.pgh.pa.us> <2965386.1725835190@sss.pgh.pa.us> Comments: In-reply-to Aleksander Alekseev message dated "Wed, 11 Sep 2024 12:32:50 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3810911.1726063269.1@sss.pgh.pa.us> Date: Wed, 11 Sep 2024 10:01:09 -0400 Message-ID: <3810912.1726063269@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Aleksander Alekseev writes: > I'm having difficulties applying the patch. Could you please do `git > format-patch` and resend it? patch(1) is generally far more forgiving than 'git am'. regards, tom lane