public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Ilia Evdokimov <[email protected]>
Cc: Andrei Lepikhov <[email protected]>
Cc: [email protected]
Subject: Re: explain analyze rows=%.0f
Date: Fri, 21 Feb 2025 21:11:07 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobXwtS0ncAVfukE-Uhhy8Zt5rQWwQb2WHBcSop8r4Lcgw@mail.gmail.com>
References: <CA+TgmoZv8DvmeQHQAX+rkn68id2N+DoUhFZB36d-_w1tyAeqeA@mail.gmail.com>
<[email protected]>
<CAFY6G8dgp494Xi2+VUUyM2CvuSQ+3nnzWi44gURWbCHjEWW89g@mail.gmail.com>
<[email protected]>
<CA+Tgmobgkh5CW=4Xpejw9nR6Onv8SZh0nnr+=HmNAFyyHZb0eg@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmobT9gPQLtw143oGnKVNtaOrTDOy+ZbLfe18MVZ9POjaWg@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmoYzawdq40C5cN==LRPBvQChZ7t5XxH6wv+zMxnyM7LjBQ@mail.gmail.com>
<[email protected]>
<CA+TgmobfeePej0uNfbLy0v6jUrB3D9m1Kh+QQ40_-A9KQjkqUw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmobVWYnYDj1HZ--iqeKx+n7zTgtYCar+YfZ0V6wiX-t0Mg@mail.gmail.com>
<[email protected]>
<CA+TgmoYp1K! [email protected]>
<CA+Tgmoaob_3aNF5S49WFoJs6Rb37rNnd5WH_e9nXAn_jtWWCLQ@mail.gmail.com>
<[email protected]>
<CA+TgmobXwtS0ncAVfukE-Uhhy8Zt5rQWwQb2WHBcSop8r4Lcgw@mail.gmail.com>
Robert Haas <[email protected]> writes:
> Yeah, I pushed an attempt at a band-aid fix. Hopefully that will make
> it clear whether there are other problems and how bad they are. It
> looks like the XversionUpgrade tests are not this commit's fault.
They are not, they're Jeff's problem.
I apologize if I ruffled your feathers. But the buildfarm is a shared
resource and it doesn't do to leave it significantly broken over a
weekend, which I feared you might be about to do. Committing stuff
at 4PM on a Friday is perhaps not the best plan if your intention
is to not work weekends.
On a positive note, at least some of the formerly-pink members
seem to be happy now. So as you hoped, we can get more info about
whether there are less-frequent problems.
As for a permanent fix: maybe, instead of printing fractions when
actual nloops > 1, we should print fractions if *potential*
nloops > 1? That is, anytime we're on the inside of a nestloop,
under a Gather, etc. Seems like this'd not be too hard to track
while recursively descending the PlanState tree.
regards, tom lane
view thread (38+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: explain analyze rows=%.0f
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox