From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: =?iso-8859-1?Q?Fabr=EDzio?= de Royes Mello <fabriziomello@gmail.com>,
        Dong Wook Lee <sh95119@gmail.com>,
        Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add pg_freespacemap extension sql test
In-reply-to: <Yju992Vtd/nhArwL@paquier.xyz>
References: 
 <CAAcByaKWYktP-DdZMZ-NSKiuXK5XtGKTKM5P8ae1EfNF2EKguA@mail.gmail.com>
 <368485.1646756358@sss.pgh.pa.us>
 <CAAcByaLieDjN7ra=T8g2DB_MvO6vmNwOOmtMsPoBzCb7XoSzVw@mail.gmail.com>
 <YirjZxEFY9eq/opN@paquier.xyz>
 <CAAcByaKpSkoJA8v-6FAyZaXEJJHbnBhDhrdDq_c+KXOwwcGehw@mail.gmail.com>
 <CAAcByaJbRkkRkxaGKbvZS-K_Qz3A2TA7TjVVnNQgp74u8zUS=w@mail.gmail.com>
 <CAFcNs+r-jBAE8RQqNqC+W5Li+N6xACVnAGvAFNwoWuAVEqZrDg@mail.gmail.com>
 <CAAcByaLk_Q0VHyBHuTGrV3AGT8z=qasD5pEK6CYJKMbL7iX+zw@mail.gmail.com>
 <Yjq4qwIVrjb2wYa+@paquier.xyz>
 <CAFcNs+r-2R0+XzscJxtHQO3miRTbaqoovLTQkXQ_j_sUO=woGg@mail.gmail.com>
 <Yju992Vtd/nhArwL@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 24 Mar 2022 09:40:23 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <381909.1648401526.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 27 Mar 2022 13:18:46 -0400
Message-ID: <381910.1648401526@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/381910.1648401526%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Yes, we could extend that more.  For now, I am curious to see what the
> buildfarm has to say with the current contents of the patch, and I can
> keep an eye on the buildfarm today, so I have applied it.

It seems this is unstable under valgrind [1]:

--- /mnt/resource/bf/build/skink-master/HEAD/pgsql/contrib/pg_freespacemap=
/expected/pg_freespacemap.out	2022-03-24 09:39:43.974477703 +0000
+++ /mnt/resource/bf/build/skink-master/HEAD/pgsql.build/contrib/pg_freesp=
acemap/results/pg_freespacemap.out	2022-03-27 17:07:23.896287669 +0000
@@ -60,6 +60,7 @@
     ORDER BY 1, 2;
        id        | blkno | is_avail =

 -----------------+-------+----------
+ freespace_tab   |     0 | t
  freespace_brin  |     0 | f
  freespace_brin  |     1 | f
  freespace_brin  |     2 | t
@@ -75,7 +76,7 @@
  freespace_hash  |     7 | f
  freespace_hash  |     8 | f
  freespace_hash  |     9 | f
-(15 rows)
+(16 rows)
 =

 -- failures with incorrect block number
 SELECT * FROM pg_freespace('freespace_tab', -1);

skink has passed several runs since the commit went in, so it's
"unstable" not "fails consistently".  I see the test tries to
disable autovacuum on that table, so that doesn't seem to be
the problem ... what is?

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dskink&dt=3D2=
022-03-27%2008%3A26%3A20