From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Dipesh Pandit <dipesh.pandit@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Jeevan Ladhe <jeevanladhe.os@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "Shinoda,
    Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
        Abhijit Menon-Sen <ams@toroid.org>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>,
        Mark Dilger <mark.dilger@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c (zstd workers)
In-reply-to: 
 <CA+Tgmobummc+reyzZJwnua7KXPC9sromDqYx1uoZ49mxq=LRfQ@mail.gmail.com>
References: 
 <CA+TgmoaYrNxoGB8x_7Fk5uKXfbyMVAdSXTnfQN-1zu_3gB_v=Q@mail.gmail.com>
 <20220314171152.GU28503@telsasoft.com>
 <CA+TgmoYfV1ASq0QVR1QHaJnXfr+fPLoPByQL1SfWqjUuKtX_UA@mail.gmail.com>
 <CA+TgmoYvpetyRAbbg1M8b3-iHsaN4nsgmWPjOENu5-doHuJ7fA@mail.gmail.com>
 <20220317194130.GM28503@telsasoft.com>
 <CA+TgmoaaDXOT+vFDcPrnXjPTU7oFPY2_pkeQFTdSGJfrqO2LNQ@mail.gmail.com>
 <20220320194050.GX28503@telsasoft.com>
 <CA+TgmoY90uUaqtx133BsH26ZabTRK-J5VoOsGga_wRw8+HdWpQ@mail.gmail.com>
 <20220321131833.GB28503@telsasoft.com>
 <CA+TgmoZz-F1pA1Vv=-6FOPWuS1eFi2ifNyySV4u6pW0+FBeG-g@mail.gmail.com>
 <20220321182256.GC28503@telsasoft.com>
 <CA+TgmoYJ=9Y=+fJ9WyAXAExTmpArCZEdRu1iVQ_2je+heTZGrg@mail.gmail.com>
 <871qyvrvvm.fsf@wibble.ilmari.org>
 <CA+Tgmobummc+reyzZJwnua7KXPC9sromDqYx1uoZ49mxq=LRfQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Tue, 22 Mar 2022 11:37:57 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <384290.1648403267.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 27 Mar 2022 13:47:47 -0400
Message-ID: <384291.1648403267@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/384291.1648403267%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> [ v5-0001-Replace-BASE_BACKUP-COMPRESSION_LEVEL-option-with.patch ]

Coverity has a nitpick about this:

/srv/coverity/git/pgsql-git/postgresql/src/common/backup_compression.c: 19=
4 in parse_bc_specification()
193     		/* Advance to next entry and loop around. */
>>>     CID 1503251:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "vend" suggests that it may be null, but it has alre=
ady been dereferenced on all paths leading to the check.
194     		specification =3D vend =3D=3D NULL ? kwend + 1 : vend + 1;
195     	}
196     }

Not sure if you should remove this null-check or add some other ones,
but I think you ought to do one or the other.

			regards, tom lane