From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
cc: =?UTF-8?Q?Filip_Rembia=c5=82kowski?= <filip.rembialkowski@gmail.com>,
        Pgsql Hackers <pgsql-hackers@postgresql.org>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Alexander Korotkov <a.korotkov@postgrespro.ru>,
        Oleg Bartunov <obartunov@postgrespro.ru>,
        Thomas Munro <thomas.munro@gmail.com>,
        Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: fix for BUG #3720: wrong results at using ltree
In-reply-to: <3007.1585605566@sss.pgh.pa.us>
References: 
 <CAP_rww=waX2Oo6q+MbMSiZ9ktdj6eaJj0cQzNu=Ry2cCDij5fw@mail.gmail.com>
 <28639.1554565562@sss.pgh.pa.us>
 <CA+hUKGKVbTGHGpHBX6EGew13CrfYcagThJqBAmeATCMKnVqisQ@mail.gmail.com>
 <CAF4Au4yV8vsgA_7XCce4kFUa2BjseqWj=KVuOwcE+DGLj6AW7g@mail.gmail.com>
 <5eedfd9e-2f14-a2df-3bd9-4c92eb0f08a5@postgrespro.ru>
 <CAPpHfdsvEaqXDsLWebQ4Q4GszRZ_P6h-1_cidmiqPMtWzXnmhA@mail.gmail.com>
 <20200124182915.zz7hzdkijzsb4ic4@development>
 <a315c67d-5b3b-8005-99ef-daa9ea7036a0@postgrespro.ru>
 <19375.1585438012@sss.pgh.pa.us> <15582.1585529626@sss.pgh.pa.us>
 <23304.1585591242@sss.pgh.pa.us>
 <943dc224-eb82-8abd-15c3-f4b516f89767@postgrespro.ru>
 <3007.1585605566@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 30 Mar 2020 17:59:26 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3842.1585606362.1@sss.pgh.pa.us>
Date: Mon, 30 Mar 2020 18:12:42 -0400
Message-ID: <3843.1585606362@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I dunno, that doesn't really seem clearer to me (although some of it
> might be that you expended no effort on making the comments match
> the new code logic).

... although looking closer, this formulation does have one very nice
advantage: for the typical non-star case with high = low = 1, the
only recursive call is a tail recursion, so it ought to consume less
stack space than what I wrote.

Let me see what I can do with the comments.

			regards, tom lane