Message-ID: <3860919f09b1edc31f5c19adb3260836afd3283c.camel@j-davis.com>
Subject: Re: pg_dump --with-* options
From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut
 <peter@eisentraut.org>,  pgsql-hackers <pgsql-hackers@postgresql.org>
Date: Sat, 02 Aug 2025 08:30:07 -0700
In-Reply-To: <aI1Dz1DXe_gaqwOZ@nathan>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
	 <aEMLzPQtjRbj2R7X@nathan>
	 <CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
	 <aErpuM6RXSlK1FBW@nathan>
	 <7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
	 <5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
	 <aFLenfMRS9jFINxq@nathan>
	 <031558c60e84362898922caa6a90587e7fdf2a57.camel@j-davis.com>
	 <f379d0aeefe8effe13302a436bc28f549f09e924.camel@j-davis.com>
	 <40cedfc22da152928a74d472708aaadb8855d8d9.camel@j-davis.com>
	 <aI1Dz1DXe_gaqwOZ@nathan>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/3860919f09b1edc31f5c19adb3260836afd3283c.camel%40j-davis.com>
Precedence: bulk

On Fri, 2025-08-01 at 17:46 -0500, Nathan Bossart wrote:
> On Fri, Aug 01, 2025 at 12:42:16PM -0700, Jeff Davis wrote:
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <term><option>--with-statistics</option=
></term>
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <term><option>--statistics</option></te=
rm>
>=20
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <term><option>--with-statistics</option=
></term>
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <term><option>--statistics</option></te=
rm>
>=20
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <term><option>--with-statistics</option=
></term>
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <term><option>--statistics</option></te=
rm>
>=20
> nitpick: --statistics should be moved to maintain alphabetical
> ordering.
>=20

Thank you. I committed this and closed the Open Item.

I did not address the following issues:

  * Did not change default to on: there was no consensus on this point,
and the default-off opinions were stronger. We may be able to revisit
for PG19.
  * Did not add --include syntax: no patch and no consensus on the
details.
  * Did not remove redundant --no-statistics option for pg_dump and
redundant --statistics option for pg_restore: kept for consistency
between pg_dump and pg_restore, and to allow us to potentially change
to default-on in the future.

If someone feels one of these needs to be addressed in PG18, let me
know.

Regards,
	Jeff Davis