public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: David Steele <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Possible regression setting GUCs on \connect
Date: Thu, 18 May 2023 14:33:16 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZb=krMdR-G4qR3Vc3ezWPx73XSKntHw0Y9HFHFE0Fzrw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20230427221443.GA1987000@nathanxps13>
	<[email protected]>
	<CAPpHfdsy-jxhgR0bWk1Fv63c6txwMAkzxFMGMf29jqa9uU_CdQ@mail.gmail.com>
	<CAA4eK1JStDCDqNC7uz-FQVKqyxhTywjitE4W=HomSogjw0S_Tw@mail.gmail.com>
	<[email protected]>
	<CAPpHfdtRHVYh+nPwehFua0vJ4=EVrTrc7pAAuBfBRcVHPf7DAA@mail.gmail.com>
	<CA+TgmoZb=krMdR-G4qR3Vc3ezWPx73XSKntHw0Y9HFHFE0Fzrw@mail.gmail.com>

Robert Haas <[email protected]> writes:
> This discussion made me go back and look at the commit in question. My
> opinion is that the feature as it was committed is quite hard to
> understand. The documentation for it said this: "Specifies that
> variable should be set on behalf of ordinary role." But what does that
> even mean? What's an "ordinary role"? What does "on behalf of" mean?

Yeah.  And even more to the point: how would the feature interact with
per-user grants of SET privilege?  It seems like it would have to ignore
or override that, which is not a conclusion I like at all.

I think that commit a0ffa885e pretty much nailed down the user interface
we want, and what remains is to work out how granting SET privilege
interacts with the time-delayed nature of ALTER USER/DATABASE SET.
But the answer to that does not seem difficult to me: remember who
issued the ALTER and see if they still have SET privilege at the time
we activate a particular entry.

			regards, tom lane

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Possible regression setting GUCs on \connect
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox