public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: post-freeze damage control
Date: Tue, 09 Apr 2024 17:05:02 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAPpHfdty3i7qFcorB_9G=BjZNT-4z=X4facS0qpVmBewgvR8+g@mail.gmail.com>
References: <CA+TgmoZS9zGgUyFeihqo=piuNhHEiRcYDHXMOkt40dUGx9n8Tg@mail.gmail.com>
<[email protected]>
<CAPpHfdshH90mDRriZABbS1sBFcjo4-uDJN3T9zB0G42pRSxiEQ@mail.gmail.com>
<[email protected]>
<CAPpHfdty3i7qFcorB_9G=BjZNT-4z=X4facS0qpVmBewgvR8+g@mail.gmail.com>
Alexander Korotkov <[email protected]> writes:
> On Tue, Apr 9, 2024 at 11:37 PM Tom Lane <[email protected]> wrote:
>> What exactly is the point of having a NodeTag in the struct though?
>> If you don't need it to be a valid Node, that seems pointless and
>> confusing. We certainly have plenty of other lists that contain
>> plain structs without tags, so I don't buy that the List
>> infrastructure is making you do that.
> This code mixes Expr's and hash entries in the single list. The point
> of having a NodeTag in the struct is the ability to distinguish them
> later.
If you're doing that, it really really ought to be a proper Node.
If nothing else, that would aid debugging by allowing the list
to be pprint'ed.
regards, tom lane
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: post-freeze damage control
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox