From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jan Wieck <jan@wi3ck.info>
cc: Magnus Hagander <magnus@hagander.net>,
        Robins Tharakan <tharakan@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Fix pg_upgrade to preserve datdba
In-reply-to: <ff77882d-1b1f-1735-402a-f4583f1b2f58@wi3ck.info>
References: <a9f9376f1c3343a6bb319dce294e20ac@EX13D05UWC001.ant.amazon.com>
 <CABUevEwyLb9VE0D+bAQtUnaA7bffXYzBpopYuh7kGTQxY9T5_g@mail.gmail.com>
 <CAEP4nAw2WA1wyb9LG7BOEuN3Xr-xWiZZ0w_hKtpyvdUPKmcAJA@mail.gmail.com>
 <1742698.1615221182@sss.pgh.pa.us>
 <CABUevEzvU07CqwGdaOmxNfDtrkY-xEcLjiN3GAmurowyCnbG7w@mail.gmail.com>
 <1743618.1615222719@sss.pgh.pa.us>
 <4fbf92f2-ec91-f4fa-a259-f0968e34f3d7@wi3ck.info>
 <0b5d506d-70d2-1506-bbdf-89e6453c0289@wi3ck.info>
 <384713.1616345832@sss.pgh.pa.us>
 <2284b71d-af55-2625-f8c2-cedf1f1a70ca@wi3ck.info>
 <ff77882d-1b1f-1735-402a-f4583f1b2f58@wi3ck.info>
Comments: In-reply-to Jan Wieck <jan@wi3ck.info>
	message dated "Sun, 21 Mar 2021 13:50:45 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <388154.1616351018.1@sss.pgh.pa.us>
Date: Sun, 21 Mar 2021 14:23:38 -0400
Message-ID: <388155.1616351018@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/388155.1616351018%40sss.pgh.pa.us>
Precedence: bulk

Jan Wieck <jan@wi3ck.info> writes:
>> On 3/21/21 12:57 PM, Tom Lane wrote:
>>> I think maybe what we have here is a bug in pg_restore, its
>>> --create switch ought to be trying to update the database's
>>> ownership.

> Thanks for that. I like this patch a lot better.

Needs a little more work than that --- we should allow it to respond
to the --no-owner switch, for example.  But I think likely we can do
it where other object ownership is handled.  I'll look in a bit.

			regards, tom lane