From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Erik Rijkers <er@xs4all.nl>, Pavel Stehule <pavel.stehule@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Julien Rouhaud <rjuju123@gmail.com>,
        "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Andrew Dunstan <andrew@dunslane.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Tomas Vondra <tomas.vondra@enterprisedb.com>,
        Dean Rasheed <dean.a.rasheed@gmail.com>,
        Stephen Frost <sfrost@snowman.net>,
        Surafel Temesgen <surafel3000@gmail.com>,
        vignesh C <vignesh21@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: proposal: possibility to read dumped table's name from file
In-reply-to: <6714E9BB-9EA3-486A-B7AC-976D97301F61@yesql.se>
References: 
 <CAFj8pRBmN1AGm7wBk8279_mf-vCd6vaiY+tJ=dOLrn9p1LAL8w@mail.gmail.com>
 <CAFj8pRAGiNnOUEE5zf3yD60Y82qyLB_ehC=rUNPks0FHULR+oQ@mail.gmail.com>
 <ZBcVz5Gymrv23Ntu@telsasoft.com>
 <CAFj8pRDN8_jqzk8SppfYLeXw02XeNf_zYO28ZjjPf1hcQFe30g@mail.gmail.com>
 <ZBnN9x71hH8F/LQv@telsasoft.com>
 <CAFj8pRBqpMvqTLftpte5cQWa=8-Hd6nSZ6PiyXgRvRXu1-N_Ow@mail.gmail.com>
 <CAFj8pRA25Kg1_skQKic1cyLThrNuwY+uDU4ozuCsm2JthmdLdw@mail.gmail.com>
 <CAFj8pRAHQb0CBh33rrJUc67f+2Meug8NqWa1Qfv8CaDCzQ+CCQ@mail.gmail.com>
 <CAFj8pRAKFoPSg392t_Mc1612H7icdf2cKXt_vtzObtyK=PwaNw@mail.gmail.com>
 <70FC9210-B636-4863-9138-B126176D6BE2@yesql.se>
 <CAFj8pRA4LebAbgT-VyhJbrZzzVJ2d8p5K1vBrzJuxWBKeHa8iw@mail.gmail.com>
 <CAFj8pRAZ8DNZY_Wevp7JvD+vw3B87E=B39qkKuXUG9tUCzyDAg@mail.gmail.com>
 <87B9339B-3492-465A-AD06-F4DDE918696D@yesql.se>
 <CAFj8pRB7yGMO+s5U=40HWbS3GEaMw554mJzAhiTjKuky90vRzQ@mail.gmail.com>
 <CAFj8pRD_yAue_M2WPMAU1jw2_ONyAGaTwsD1CyFTrwmFYo6Zvw@mail.gmail.com>
 <A7D7ED17-A2FD-43D7-94B1-8E354B6F22A8@yesql.se> <8186e8f!
 0-fc8b-3d67-5e9d-c1e3e8e26040@xs4all.nl>
 <6714E9BB-9EA3-486A-B7AC-976D97301F61@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 29 Nov 2023 15:43:58 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <388185.1701315586.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 29 Nov 2023 22:39:46 -0500
Message-ID: <388186.1701315586@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/388186.1701315586%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> I took another look at this, found some more polish that was needed, add=
ed
> another testcase and ended up pushing it.

mamba is unhappy because this uses <ctype.h> functions without
casting their arguments to unsigned char:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmamba&dt=3D2023-=
11-30%2002%3A53%3A25

(I had not realized that we still had buildfarm animals that would
complain about this ... but I'm glad we do, because it's a hazard.
POSIX is quite clear that the behavior is undefined for signed chars.)

			regards, tom lane