From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Daniel Gustafsson <daniel@yesql.se>,
        bt23nguyent <bt23nguyent@oss.nttdata.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when
 basic_archive.archive_directory parameter is not set
In-reply-to: <20240304215048.GA3367383@nathanxps13>
References: <D3038255-EAB5-4164-A9E3-7967B6738993@yesql.se>
 <18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>
 <20230925222047.GA3173226@nathanxps13>
 <482056B1-D930-417C-9473-CB1A045E42AE@yesql.se>
 <20231013022559.GA1266364@nathanxps13>
 <E863EDCA-EFEA-4DFA-9E93-024D464DE260@yesql.se>
 <20240105230357.GA2425960@nathanxps13>
 <AB31C950-5BA6-49F2-ADF9-F8E8334EB4A2@yesql.se>
 <20240304172252.GA3161951@nathanxps13>
 <1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se>
 <20240304215048.GA3367383@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Mon, 04 Mar 2024 15:50:48 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3884543.1709589924.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Mon, 04 Mar 2024 17:05:24 -0500
Message-ID: <3884544.1709589924@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3884544.1709589924%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Mar 04, 2024 at 09:27:23PM +0100, Daniel Gustafsson wrote:
>> Reviewed-by: Daniel Gustafsson, ¡lvaro Herrera
>> Alvaro's name seems wrong.

> Hm.  It looks alright to me.  I copied the name from his e-mail signature,
> which has an accent over the first 'A'.  I assume that's why it's not
> showing up correctly in some places.

I think that git has an expectation of commit log entries being in
UTF8.  The committed message looks okay from my end, but maybe some
encoding mangling happened to the version Daniel was looking at?

			regards, tom lane