From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jan Wieck <jan@wi3ck.info>
cc: Magnus Hagander <magnus@hagander.net>,
        Robins Tharakan <tharakan@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Fix pg_upgrade to preserve datdba
In-reply-to: <388155.1616351018@sss.pgh.pa.us>
References: <a9f9376f1c3343a6bb319dce294e20ac@EX13D05UWC001.ant.amazon.com>
 <CABUevEwyLb9VE0D+bAQtUnaA7bffXYzBpopYuh7kGTQxY9T5_g@mail.gmail.com>
 <CAEP4nAw2WA1wyb9LG7BOEuN3Xr-xWiZZ0w_hKtpyvdUPKmcAJA@mail.gmail.com>
 <1742698.1615221182@sss.pgh.pa.us>
 <CABUevEzvU07CqwGdaOmxNfDtrkY-xEcLjiN3GAmurowyCnbG7w@mail.gmail.com>
 <1743618.1615222719@sss.pgh.pa.us>
 <4fbf92f2-ec91-f4fa-a259-f0968e34f3d7@wi3ck.info>
 <0b5d506d-70d2-1506-bbdf-89e6453c0289@wi3ck.info>
 <384713.1616345832@sss.pgh.pa.us>
 <2284b71d-af55-2625-f8c2-cedf1f1a70ca@wi3ck.info>
 <ff77882d-1b1f-1735-402a-f4583f1b2f58@wi3ck.info>
 <388155.1616351018@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sun, 21 Mar 2021 14:23:38 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <388709.1616351698.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 21 Mar 2021 14:34:58 -0400
Message-ID: <388710.1616351698@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/388710.1616351698%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Needs a little more work than that --- we should allow it to respond
> to the --no-owner switch, for example.  But I think likely we can do
> it where other object ownership is handled.  I'll look in a bit.

Actually ... said code already DOES do that, so now I'm confused.
I tried

regression=3D# create user joe;
CREATE ROLE
regression=3D# create database joe owner joe;
CREATE DATABASE
regression=3D# \q
$ pg_dump -Fc joe >joe.dump
$ pg_restore --create -f - joe.dump | more

and I see

--
-- Name: joe; Type: DATABASE; Schema: -; Owner: joe
--

CREATE DATABASE joe WITH TEMPLATE =3D template0 ENCODING =3D 'SQL_ASCII' L=
OCALE =3D 'C';


ALTER DATABASE joe OWNER TO joe;

so at least in this case it's doing the right thing.  We need a bit
more detail about the context in which it's doing the wrong thing
for you.

			regards, tom lane