From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Alexander Korotkov <a.korotkov@postgrespro.ru>,
        Jeff Janes <jeff.janes@gmail.com>,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Andres Freund <andres@anarazel.de>,
        Oleg Bartunov <obartunov@postgrespro.ru>,
        Michael Paquier <michael@paquier.xyz>,
        Stas Kelvich <s.kelvich@postgrespro.ru>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        David Steele <david@pgmasters.net>,
        Robert Haas <robertmhaas@gmail.com>,
        Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: jsonpath
In-reply-to: <d47b2023-3ecb-5f04-d253-d557547cf74f@2ndQuadrant.com>
References: 
 <CAPpHfdv2bro1224314aRijKJu1bfwEimKr6hExoOaF4sqSDTQA@mail.gmail.com>
 <20190130022826.of7w6xv5lbvzqxfp@alap3.anarazel.de>
 <CAPpHfdvov6kWfT3hk8KMSah+kzNuN2AXaZfBqnSU0YkzDVkR2Q@mail.gmail.com>
 <957ee2ff-f9a6-0ba1-13e2-9c4d320f63ac@2ndquadrant.com>
 <CAPpHfdu+y1tkiidwu0i=XyGK5eOTOu1fPbuYs=XT32g7tzGd4Q@mail.gmail.com>
 <a3be6a7a-77d3-0e88-4f9d-4f725d11d7cd@postgrespro.ru>
 <CAPpHfdsW924B1eYLqgXE0SkH0ym2Zk32CqPwUu_CH65Gk_onrA@mail.gmail.com>
 <c25eb8a5-a129-bb7e-c930-761f0e2a6b71@2ndquadrant.com>
 <67128b8b-2d80-9e51-20a8-9ac8e0e2243e@2ndquadrant.com>
 <CAPpHfdsyWVfW7N-T9-H1RjoRZCwQX4w5qRd6SGjbLP=qf_y9iw@mail.gmail.com>
 <CAPpHfdsLuSAGHbn06Qq83=XCDhW8RqFe8tFeq+rYhiNWD=bzFA@mail.gmail.com>
 <CAPpHfduXPikbeCnaVi1d2GQvKJLJcQ_GEe5KrzSPTV1KD0E8+Q@mail.gmail.com>
 <CAMkU=1w1qBvoW82ZTFpAKae027R-2OHw-m6ALe0VQRNAFueBVA@mail.gmail.com>
 <32541.1552759144@sss.pgh.pa.us> <3448.1552759918@sss.pgh.pa.us>
 <CAPpHfduahCFm6yVrs+_cPO8cn75pePgoCG4hWA=tOy3RzZJRpg@mail.gmail.com>
 <d47b2023-3ecb-5f04-!
 d253-d557547cf74f@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Sun, 17 Mar 2019 10:00:44 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3884.1552835005.1@sss.pgh.pa.us>
Date: Sun, 17 Mar 2019 11:03:25 -0400
Message-ID: <3890.1552835005@sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> Why are we installing the jsonpath_gram.h file? It's not going to be
> used by anything else, is it? TBH, I'm not sure I see why we're
> installing the scanner.h file either.

As near as I can see, jsonpath_gram.h and jsonpath_scanner.h exist only
for communication between jsonpath_gram.y and jsonpath_scan.l.  Maybe
we'd be better off handling that need by compiling the .l file as part
of the .y file, as we used to do with the core lexer and still do with
several others (cf comments for commit 72b1e3a21); then we wouldn't
even have to generate these files much less install them.

A quick look at jsonpath_scan.c shows that it's pretty innocent of
the tricks we've learned over the years for flex/bison portability;
in particular I see that it's #including <stdio.h> before postgres.h,
which is a no-no.  So that whole area needs more review anyway.

			regards, tom lane