Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1l1awW-0001P5-BT
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 20:16:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1l1awV-0002ud-8r
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 20:16:03 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1l1awV-0002uW-2Y
	for pgsql-hackers@lists.postgresql.org; Mon, 18 Jan 2021 20:16:03 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1l1awO-0005a5-VO
	for pgsql-hackers@postgresql.org; Mon, 18 Jan 2021 20:16:02 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 10IKFsId389042;
	Mon, 18 Jan 2021 15:15:54 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zhihong Yu <zyu@yugabyte.com>
cc: David Geier <david@swarm64.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: search_plan_tree(): handling of non-leaf CustomScanState nodes
 causes segfault
In-reply-to: 
 <CALNJ-vRRwwqKuSvWJNdHG7Six0ZBt=LDVdrFfSitStuKHbjUkg@mail.gmail.com>
References: <0253344d-9bdd-11c4-7f0d-d88c02cd7991@swarm64.com>
 <347100.1610995608@sss.pgh.pa.us>
 <CALNJ-vRRwwqKuSvWJNdHG7Six0ZBt=LDVdrFfSitStuKHbjUkg@mail.gmail.com>
Comments: In-reply-to Zhihong Yu <zyu@yugabyte.com>
	message dated "Mon, 18 Jan 2021 11:23:42 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <389040.1611000954.1@sss.pgh.pa.us>
Date: Mon, 18 Jan 2021 15:15:54 -0500
Message-ID: <389041.1611000954@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Zhihong Yu <zyu@yugabyte.com> writes:
> It seems sstate->ss_currentRelation being null can only
> occur for T_ForeignScanState and T_CustomScanState.
> What about the following change ?

Seems like more code for no very good reason.

			regards, tom lane