From: Tom Lane <tgl@sss.pgh.pa.us>
To: jian he <jian.universality@gmail.com>
cc: Tommy Pavlicek <tommypav122@gmail.com>,
        =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        pgsql-hackers@lists.postgresql.org,
        Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: Re: [PATCH] Extend ALTER OPERATOR to support adding commutator,
 negator, hashes, and merges
In-reply-to: 
 <CACJufxFrPNGs3Ws7HQLgXqR2YnnDmgGGqtmEULU-nu7oyc13gQ@mail.gmail.com>
References: 
 <CAEhP-W-vGVzf4udhR5M8Bdv88UYnPrhoSkj3ieR3QNrsGQoqdg@mail.gmail.com>
 <4077062.1687452468@sss.pgh.pa.us> <87r0q3qvxd.fsf@wibble.ilmari.org>
 <4082750.1687455374@sss.pgh.pa.us>
 <CAEhP-W_xGQVmiEJE_x0x5bbDSwsmaN1TQEawNadiMvQj2XK2Sg@mail.gmail.com>
 <15382.1687519306@sss.pgh.pa.us>
 <CAEhP-W-bY5CTXgrsH_J=NyKJpqMOgUPqMQ9-oTtx2N+zND1ZuA@mail.gmail.com>
 <1092363.1695932314@sss.pgh.pa.us>
 <CAEhP-W8MjoA0yDCipp=FgZvoQA-OVjQws3-XO6bpCWXunO8t8A@mail.gmail.com>
 <447166.1696969927@sss.pgh.pa.us>
 <CAEhP-W_1bMTLan2LtzS+xr=b-Wep56gw+OoirABQ8b2aOw+5yg@mail.gmail.com>
 <CACJufxFrPNGs3Ws7HQLgXqR2YnnDmgGGqtmEULU-nu7oyc13gQ@mail.gmail.com>
Comments: In-reply-to jian he <jian.universality@gmail.com>
	message dated "Thu, 12 Oct 2023 11:53:53 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3891594.1697819583.1@sss.pgh.pa.us>
Date: Fri, 20 Oct 2023 12:33:03 -0400
Message-ID: <3891595.1697819583@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3891595.1697819583%40sss.pgh.pa.us>
Precedence: bulk

jian he <jian.universality@gmail.com> writes:
> errmsg("operator attribute \"negator\" cannot be changed if it has
> already been set")));
> I feel like the above message is not very helpful.

I think it's okay to be concise about this as long as the operator
we're referring to is the target of the ALTER.  I agree that when
we're complaining about some *other* operator, we'd better spell
out which one we mean, and I made some changes to the patch to
improve that.

Pushed after a round of editorialization -- mostly cosmetic
stuff, except for tweaking some error messages.  I shortened the
test cases a bit too, as I thought they were somewhat excessive
to have as a permanent thing.

			regards, tom lane