Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------LjE456vkXEleC8H0CS0jgMnc"
Message-ID: <38c53446-6b65-4222-b76b-351e56f4841c@eisentraut.org>
Date: Thu, 6 Mar 2025 14:46:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: RFC: Additional Directory for Extensions
To: Matheus Alcantara <matheusssilv97@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>
Cc: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>,
 Craig Ringer <craig.ringer@enterprisedb.com>,
 "David E. Wheeler" <david@justatheory.com>,
 Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera
 <alvherre@alvh.no-ip.org>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <CA+TgmoaMk==vOUmWwJ5ZA-EueNqa9RQaWMEiHCF1ZKW_YCcj8g@mail.gmail.com>
 <CA+VUV5oWkMVvtNB0BG2CM8SrmOkeW6fEtXGehbniHqR9MhMzVw@mail.gmail.com>
 <CAGRY4nxP6A5Dz23g+aGD-agdVwUj_qrG6szd-mWc0E5OFMBg4w@mail.gmail.com>
 <B86AF59F-5B65-4CC9-91A4-B79A089C2876@justatheory.com>
 <CAGRY4ny=Oy-F0qCRFQa=XtEqyUbMygvbqqKahAvbae7v4LTOrQ@mail.gmail.com>
 <AF4A50CD-C5CF-406D-9700-1B889F40E8FB@justatheory.com>
 <CAGRY4nx8Fmea4udk--PKdvfgpNdqC+rcueAmGwuw2PD9dv+zqQ@mail.gmail.com>
 <D30A91FA-A6D4-4737-941F-0BBB2984B730@justatheory.com>
 <0d384836-7e6e-4932-af3b-8dad1f6fee43@eisentraut.org>
 <4f7209ba-1ca2-475e-9a70-0f3fe0be6378@eisentraut.org>
 <CAFY6G8dzuLXFjONX5E-TvyD5E9r21b5vp1My_nMcqdGD0VYfYw@mail.gmail.com>
 <12312928-5516-49b8-81c1-a7b56fd01bc8@dunslane.net>
 <CAFY6G8dGcv1D8tCkjrz+9DvAYG9h4U=hBm0VXjJEXExy44hauQ@mail.gmail.com>
 <CAFY6G8eOMkGXLqzUz=qXrwt4X_HvmVZ13570DAbgAiw+3q03DA@mail.gmail.com>
 <CAFY6G8fV5FTqn7p8pxbvPYUD5+ffik-J50GChjKH2Gg7d=fRPg@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAFY6G8fV5FTqn7p8pxbvPYUD5+ffik-J50GChjKH2Gg7d=fRPg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/38c53446-6b65-4222-b76b-351e56f4841c%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------LjE456vkXEleC8H0CS0jgMnc
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 03.03.25 19:45, Matheus Alcantara wrote:
> Hi, attached a new v5 with some minor improvements on TAP tests:
> 
> - Add a proper test name for all test cases
> - Add CREATE EXTENSION command execution
> - Change the assert on pg_available_extensions and
>    pg_available_extension_versions to validate the row content
> 
> Also rebased with master

This looks very good to me.  I have one issue to point out:  The logic 
in get_extension_control_directories() needs to be a little bit more 
careful to align with the rules in find_in_path().  For example, it 
should use first_path_var_separator() to get the platform-specific path 
separator, and probably also substitute_path_macro() and 
canonicalize_path() etc., to keep everything consistent.  (Maybe it 
would be ok to move the function to dfmgr.c to avoid having to export 
too many things from there.)

Independent of that, attached is a small patch that suggests to use the 
newer foreach_ptr() macro in some places.
--------------LjE456vkXEleC8H0CS0jgMnc
Content-Type: text/plain; charset=UTF-8;
 name="0001-Use-foreach_ptr.patch.nocfbot"
Content-Disposition: attachment; filename="0001-Use-foreach_ptr.patch.nocfbot"
Content-Transfer-Encoding: base64

RnJvbSAzNWMyMTA2NTU4MDk1ZTc0MzU5Y2VjNThiOTYzMWZhMTllZDkzN2IzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVGh1LCA2IE1hciAyMDI1IDE0OjI4OjA4ICswMTAwClN1YmplY3Q6
IFtQQVRDSF0gVXNlIGZvcmVhY2hfcHRyCgotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL2V4
dGVuc2lvbi5jIHwgMjAgKysrKysrLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2
IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNr
ZW5kL2NvbW1hbmRzL2V4dGVuc2lvbi5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvZXh0ZW5z
aW9uLmMKaW5kZXggN2U4YTI4ZTQwNjQuLjRiZGIyMGFhZjU0IDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC9jb21tYW5kcy9leHRlbnNpb24uYworKysgYi9zcmMvYmFja2VuZC9jb21tYW5k
cy9leHRlbnNpb24uYwpAQCAtNTEsMTAgKzUxLDEwIEBACiAjaW5jbHVkZSAiY29tbWFuZHMv
ZGVmcmVtLmgiCiAjaW5jbHVkZSAiY29tbWFuZHMvZXh0ZW5zaW9uLmgiCiAjaW5jbHVkZSAi
Y29tbWFuZHMvc2NoZW1hY21kcy5oIgotI2luY2x1ZGUgIm5vZGVzL3BnX2xpc3QuaCIKICNp
bmNsdWRlICJmdW5jYXBpLmgiCiAjaW5jbHVkZSAibWIvcGdfd2NoYXIuaCIKICNpbmNsdWRl
ICJtaXNjYWRtaW4uaCIKKyNpbmNsdWRlICJub2Rlcy9wZ19saXN0LmgiCiAjaW5jbHVkZSAi
bm9kZXMvcXVlcnlqdW1ibGUuaCIKICNpbmNsdWRlICJzdG9yYWdlL2ZkLmgiCiAjaW5jbHVk
ZSAidGNvcC91dGlsaXR5LmgiCkBAIC0yMTgzLDIwICsyMTgzLDE3IEBAIERhdHVtCiBwZ19h
dmFpbGFibGVfZXh0ZW5zaW9ucyhQR19GVU5DVElPTl9BUkdTKQogewogCVJldHVyblNldElu
Zm8gKnJzaW5mbyA9IChSZXR1cm5TZXRJbmZvICopIGZjaW5mby0+cmVzdWx0aW5mbzsKKwlM
aXN0CSAgICpsb2NhdGlvbnM7CiAJRElSCQkgICAqZGlyOwogCXN0cnVjdCBkaXJlbnQgKmRl
OwotCUxpc3QJICAgKmxvY2F0aW9uczsKLQlMaXN0Q2VsbCAgICpjZWxsOwogCiAJLyogQnVp
bGQgdHVwbGVzdG9yZSB0byBob2xkIHRoZSByZXN1bHQgcm93cyAqLwogCUluaXRNYXRlcmlh
bGl6ZWRTUkYoZmNpbmZvLCAwKTsKIAogCWxvY2F0aW9ucyA9IGdldF9leHRlbnNpb25fY29u
dHJvbF9kaXJlY3RvcmllcygpOwogCi0JZm9yZWFjaChjZWxsLCBsb2NhdGlvbnMpCisJZm9y
ZWFjaF9wdHIoY2hhciwgbG9jYXRpb24sIGxvY2F0aW9ucykKIAl7Ci0JCWNoYXIJICAgKmxv
Y2F0aW9uID0gKGNoYXIgKikgbGZpcnN0KGNlbGwpOwotCiAJCWRpciA9IEFsbG9jYXRlRGly
KGxvY2F0aW9uKTsKIAogCQkvKgpAQCAtMjI3MSw3ICsyMjY4LDYgQEAgcGdfYXZhaWxhYmxl
X2V4dGVuc2lvbl92ZXJzaW9ucyhQR19GVU5DVElPTl9BUkdTKQogewogCVJldHVyblNldElu
Zm8gKnJzaW5mbyA9IChSZXR1cm5TZXRJbmZvICopIGZjaW5mby0+cmVzdWx0aW5mbzsKIAlM
aXN0CSAgICpsb2NhdGlvbnM7Ci0JTGlzdENlbGwgICAqY2VsbDsKIAlESVIJCSAgICpkaXI7
CiAJc3RydWN0IGRpcmVudCAqZGU7CiAKQEAgLTIyNzksMTAgKzIyNzUsOSBAQCBwZ19hdmFp
bGFibGVfZXh0ZW5zaW9uX3ZlcnNpb25zKFBHX0ZVTkNUSU9OX0FSR1MpCiAJSW5pdE1hdGVy
aWFsaXplZFNSRihmY2luZm8sIDApOwogCiAJbG9jYXRpb25zID0gZ2V0X2V4dGVuc2lvbl9j
b250cm9sX2RpcmVjdG9yaWVzKCk7Ci0JZm9yZWFjaChjZWxsLCBsb2NhdGlvbnMpCi0Jewot
CQljaGFyCSAgICpsb2NhdGlvbiA9IChjaGFyICopIGxmaXJzdChjZWxsKTsKIAorCWZvcmVh
Y2hfcHRyKGNoYXIsIGxvY2F0aW9uLCBsb2NhdGlvbnMpCisJewogCQlkaXIgPSBBbGxvY2F0
ZURpcihsb2NhdGlvbik7CiAKIAkJLyoKQEAgLTI0NDksMTYgKzI0NDQsMTMgQEAgZXh0ZW5z
aW9uX2ZpbGVfZXhpc3RzKGNvbnN0IGNoYXIgKmV4dGVuc2lvbk5hbWUpCiB7CiAJYm9vbAkJ
cmVzdWx0ID0gZmFsc2U7CiAJTGlzdAkgICAqbG9jYXRpb25zOwotCUxpc3RDZWxsICAgKmNl
bGw7CiAJRElSCQkgICAqZGlyOwogCXN0cnVjdCBkaXJlbnQgKmRlOwogCiAJbG9jYXRpb25z
ID0gZ2V0X2V4dGVuc2lvbl9jb250cm9sX2RpcmVjdG9yaWVzKCk7CiAKLQlmb3JlYWNoKGNl
bGwsIGxvY2F0aW9ucykKKwlmb3JlYWNoX3B0cihjaGFyLCBsb2NhdGlvbiwgbG9jYXRpb25z
KQogCXsKLQkJY2hhcgkgICAqbG9jYXRpb24gPSAoY2hhciAqKSBsZmlyc3QoY2VsbCk7Ci0K
IAkJZGlyID0gQWxsb2NhdGVEaXIobG9jYXRpb24pOwogCiAJCS8qCi0tIAoyLjQ4LjEKCg==


--------------LjE456vkXEleC8H0CS0jgMnc--