Content-Type: multipart/alternative;
 boundary="------------hBI9q0Ida2KqltcRQefO2DNp"
Message-ID: <38d567be-344a-4128-ad3e-bc66d9e3103e@dunslane.net>
Date: Wed, 8 Apr 2026 09:23:43 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BF client script runs src/test/modules TAP tests multiple times
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>
References: <2996768.1775624451@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <2996768.1775624451@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/38d567be-344a-4128-ad3e-bc66d9e3103e%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------hBI9q0Ida2KqltcRQefO2DNp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2026-04-08 We 1:00 AM, Tom Lane wrote:
> I spent some more time poking into why my buildfarm animals seemed
> to have gotten markedly slower in the past month or so.  One
> particular inflection point was the introduction of test_plan_advice.
> We knew that would be expensive, since it invokes an extra run of
> the core regression tests.  On my animal indri, which can do
> install-check-C in about 10 or 11 seconds, you'd have expected that
> to add ten-ish seconds to the total cycle time.  But it added more
> than 30 seconds.  Investigation shows that what you'd guess from
> simple arithmetic is the truth: the BF client script is invoking
> that test *three times*.  Once from make_misc_check, once from
> make_testmodules_install_check with locale "C", and once from
> make_testmodules_install_check with locale "en_US.utf8", since
> that animal is set up with
> 	locales => [ 'C', 'en_US.UTF-8' ],
>
> I do not think we need this.  We should apply the same policy to
> src/test/modules as we do to contrib, namely that TAP tests are
> run just once during the "make check" phase, not during the "make
> installcheck" phases.  I've applied the attached to my animals
> and it makes for a significant drop in cycle time.
>
> (I've not looked into whether the meson side has a similar issue.)
>
> 			


Ok, I will try to rationalize this.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------hBI9q0Ida2KqltcRQefO2DNp
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2026-04-08 We 1:00 AM, Tom Lane
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:2996768.1775624451@sss.pgh.pa.us">
      <pre wrap="" class="moz-quote-pre">I spent some more time poking into why my buildfarm animals seemed
to have gotten markedly slower in the past month or so.  One
particular inflection point was the introduction of test_plan_advice.
We knew that would be expensive, since it invokes an extra run of
the core regression tests.  On my animal indri, which can do
install-check-C in about 10 or 11 seconds, you'd have expected that
to add ten-ish seconds to the total cycle time.  But it added more
than 30 seconds.  Investigation shows that what you'd guess from
simple arithmetic is the truth: the BF client script is invoking
that test *three times*.  Once from make_misc_check, once from
make_testmodules_install_check with locale "C", and once from
make_testmodules_install_check with locale "en_US.utf8", since
that animal is set up with
	locales =&gt; [ 'C', 'en_US.UTF-8' ],

I do not think we need this.  We should apply the same policy to
src/test/modules as we do to contrib, namely that TAP tests are
run just once during the "make check" phase, not during the "make
installcheck" phases.  I've applied the attached to my animals
and it makes for a significant drop in cycle time.

(I've not looked into whether the meson side has a similar issue.)

			</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Ok, I will try to rationalize this.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------hBI9q0Ida2KqltcRQefO2DNp--