pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedhint Consider using pg_file_read()
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2021-03-18 da18d829c2 0c3079e3ef a5eb70cfca 5d825d7bee Fix function name in error hint
* hint Consider using pg_file_read()
@ 2021-03-18 09:57 Sergei Kornilov <sk@zsrv.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Kornilov @ 2021-03-18 09:57 UTC (permalink / raw)
To: pgsql-hackers
Hello
In src/backend/utils/adt/genfile.c in pg_read_file we have errhint
> errhint("Consider using %s, which is part of core, instead.",
> "pg_file_read()")
Shouldn't pg_read_file() be written here?
regards, Sergei
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: hint Consider using pg_file_read()
@ 2021-03-18 10:21 Magnus Hagander <magnus@hagander.net>
parent: Sergei Kornilov <sk@zsrv.org>
0 siblings, 1 reply; 3+ messages in thread
From: Magnus Hagander @ 2021-03-18 10:21 UTC (permalink / raw)
To: Sergei Kornilov <sk@zsrv.org>; +Cc: pgsql-hackers
On Thu, Mar 18, 2021 at 10:58 AM Sergei Kornilov <sk@zsrv.org> wrote:
>
> Hello
> In src/backend/utils/adt/genfile.c in pg_read_file we have errhint
>
> > errhint("Consider using %s, which is part of core, instead.",
> > "pg_file_read()")
>
> Shouldn't pg_read_file() be written here?
Yup, it certainly looks that way. There's a really funky combination
of names between SQL and backend there that I guess threw the original
author off.
Will fix.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: hint Consider using pg_file_read()
@ 2021-03-18 10:44 Sergei Kornilov <sk@zsrv.org>
parent: Magnus Hagander <magnus@hagander.net>
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Kornilov @ 2021-03-18 10:44 UTC (permalink / raw)
To: Magnus Hagander <magnus@hagander.net>; +Cc: pgsql-hackers
I noticed that the fix has been committed, thank you!
regards, Sergei
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-03-18 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 09:57 hint Consider using pg_file_read() Sergei Kornilov <sk@zsrv.org>
2021-03-18 10:21 ` Magnus Hagander <magnus@hagander.net>
2021-03-18 10:44 ` Sergei Kornilov <sk@zsrv.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox