Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZKcn-0008VY-EK for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Sep 2022 23:19:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oZKcl-0006FX-Se for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Sep 2022 23:19:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZKcl-0006FO-JZ for pgsql-hackers@lists.postgresql.org; Fri, 16 Sep 2022 23:19:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZKcj-00013V-6b for pgsql-hackers@lists.postgresql.org; Fri, 16 Sep 2022 23:19:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28GNJpil3913124; Fri, 16 Sep 2022 19:19:51 -0400 From: Tom Lane To: Peter Geoghegan cc: PostgreSQL Hackers Subject: Re: Making C function declaration parameter names consistent with corresponding definition names In-reply-to: References: Comments: In-reply-to Peter Geoghegan message dated "Fri, 16 Sep 2022 15:42:13 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3913122.1663370391.1@sss.pgh.pa.us> Date: Fri, 16 Sep 2022 19:19:51 -0400 Message-ID: <3913123.1663370391@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > I have to admit that these inconsistencies are a pet peeve of mine. I > find them distracting, and have a history of fixing them on an ad-hoc > basis. But there are real practical arguments in favor of being strict > about it as a matter of policy -- it's not *just* neatnikism. I agree, this has always been a pet peeve of mine as well. I would have guessed there were fewer examples than you found, because I've generally fixed any such cases I happened to notice. regards, tom lane