From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Add "format" target to make and ninja to run pgindent and
 pgperltidy
In-reply-to: 
 <CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
References: <DFCDD5H4J7VX.3GJKRBBDCKQ86@jeltef.nl>
 <CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
Comments: In-reply-to Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
	message dated "Wed, 31 Dec 2025 19:24:12 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3913297.1767194804.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 31 Dec 2025 10:26:44 -0500
Message-ID: <3913298.1767194804@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3913298.1767194804%40sss.pgh.pa.us>
Precedence: bulk

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> writes:
> On Wed, Dec 31, 2025 at 5:06=E2=80=AFPM Jelte Fennema-Nio <postgres@jelt=
ef.nl> wrote:
>> This tries to make running formatting a lot easier for committers, but
>> primarily for new contributors.

> I generally like the idea. Since perltidy is not enforced regularly
> (like pgindent), running it usually ends up modifying files which are
> not part of the patch. So I avoid it if not necessary. Do you propose
> to make it optional?

The other obstacle is that not everybody will have the right version
of perltidy installed, but using some other version will create a
whole lot of extraneous noise.

On the whole I'd recommend not trying to automate the perltidy
step yet.  Cost/benefit is just not very good.

On the substance of the patch: I wonder whether we could make things
more reliable by using git metadata to figure out which .h and .c
files to point pgindent at.

			regards, tom lane