From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Melanie Plageman <melanieplageman@gmail.com>,
        Masahiko Sawada <sawada.mshk@gmail.com>,
        Tomas Vondra <tomas@vondra.me>, Noah Misch <noah@leadboat.com>,
        vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>,
        Pg Hackers <pgsql-hackers@postgresql.org>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        Nazir Bilal Yavuz <byavuz81@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Subject: Re: Confine vacuum skip logic to lazy_scan_skip
In-reply-to: 
 <CA+hUKGJ84L0yFD2S05WeCOXmBgBcYb2S5wMmzyohcMJeCwgksw@mail.gmail.com>
References: 
 <CAAKRu_ZuYsf4MNGzm7_KvG0SKsu-EtYRhFHy2x3q0heX8KLMTg@mail.gmail.com>
 <CAAKRu_bQgf4e9OveCQX++zTEJLKbZbqLeapA7SNkNuMjxcCO1w@mail.gmail.com>
 <20240306234733.nd4a636colxkgq2e@liskov>
 <CAAKRu_aiaf+CufVA5Rrksz4Lw2fvZ3M-OgdBZ8WpzvYoQY96MQ@mail.gmail.com>
 <CA+hUKGKHb3i8Wy72VCKZGA2B5djoj7tAzYAzbeS=Gwr_SdhgRw@mail.gmail.com>
 <CAAKRu_byDppRvNJ+p5kq-SmXZDQuL6L8N6D06pHbO6WnBnanWQ@mail.gmail.com>
 <CA+hUKGLY4Q4ZY4f1rvnFtv6+PkjNf8MejdPkcju3Qii9DYqqcQ@mail.gmail.com>
 <CAAKRu_bbkmwAzSBgnezancgJeXrQZXy4G4kBTd+5=cr86H5yew@mail.gmail.com>
 <20240707144944.58.nmisch@google.com>
 <CA+hUKGK3sB-T+Ao8EBCOu5M1MsCMPnPpNyXuQGkQYHU4WC35eA@mail.gmail.com>
 <20240716015226.60.nmisch@google.com>
 <CA+hUKGKN3oy0bN_3yv8hd78a4+M1tJC9z7mD8+f+yA+GeoFUwQ@mail.gmail.com>
 <eb657bfe-ba96-4aef-82f9-b952724de863@vondra.me>
 <CAAKRu_aLwANZpxHc0tC-6OT0OQT4TftDGkKAO5yigMUOv_Tcsw@mail.gmail.com>
 <85696b8e-f1bf-459e-ba97-5608c644c185@vondra.me>
 <CAAKRu_ZoOSZHexy=7YZ9W0CfeSHc1tGx7VCperZHWBxxz0gxzw@mail.gmail.com> <CA!
 AKRu_Zb-zdDUug2ZUNcK43Fmk_eebqRFebSdshaP_iTusW93Q@mail.gmail.com>
 <CAAKRu_bmx33jTqATP5GKNFYwAg02a9dDtk4U_ciEjgBHZSVkOQ@mail.gmail.com>
 <CAD21AoDu_a0bECcOuhev08J_VUUR_3wL2fBM1D7_49Vy7A1XqA@mail.gmail.com>
 <CAAKRu_YP=-Mu9rG+q8CBGFMsurMMv-8T-=is80RMr0kR+VbAfA@mail.gmail.com>
 <CAD21AoDdx87ur-YA6qz3mKO0C7-wnQJW+45H6eEkDSP_rNB8hA@mail.gmail.com>
 <CAAKRu_Zbay2UeANcg-X455Q10nZJ_XH31Qph2wM4qDrZVa28JQ@mail.gmail.com>
 <CAAKRu_bR4ghLfsgDNnHm0gK2SOcG6qicmeyaPG2y0Ppjz1G6cw@mail.gmail.com>
 <CAAKRu_ac9DMqN2sSxLLK-D6m4V=2=uKufQUrmv82mQjch4F67A@mail.gmail.com>
 <CA+hUKG+g6aXpi2FEHqeLOzE+xYw=OV+-N5jhOEnnV+F0USM9xA@mail.gmail.com>
 <CA+hUKGJ84L0yFD2S05WeCOXmBgBcYb2S5wMmzyohcMJeCwgksw@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sat, 15 Feb 2025 11:54:17 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3915748.1739574230.1@sss.pgh.pa.us>
Date: Fri, 14 Feb 2025 18:03:50 -0500
Message-ID: <3915749.1739574230@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3915749.1739574230%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Here's a patch.  Is there a tidier way to write this?

Hmm, I think not with the current set of primitives.  We could think
about refactoring them, but that's not a job for a band-aid patch.

> It should probably be back-patched to 17, because external code might
> use per-buffer data (obviously v17 core doesn't or skink would have
> told us this sooner).   It's not a good time to push to 17 today,
> though.  Push to master now to cheer skink up and 17 some time later
> when the coast is clear, or just wait?

Agreed that right now is a bad time to push this to v17 --- we need to
keep the risk factors as low as possible for the re-release.  Master
now and v17 after the re-wrap seems like the right compromise.

			regards, tom lane