From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
        Jelte Fennema-Nio <postgres@jeltef.nl>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Add "format" target to make and ninja to run pgindent and
 pgperltidy
In-reply-to: <5611b8aa-8496-4632-92b4-e096654850d1@dunslane.net>
References: <DFCDD5H4J7VX.3GJKRBBDCKQ86@jeltef.nl>
 <CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
 <3913298.1767194804@sss.pgh.pa.us>
 <5611b8aa-8496-4632-92b4-e096654850d1@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 31 Dec 2025 10:48:00 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3915954.1767196446.1@sss.pgh.pa.us>
Date: Wed, 31 Dec 2025 10:54:06 -0500
Message-ID: <3915955.1767196446@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3915955.1767196446%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2025-12-31 We 10:26 AM, Tom Lane wrote:
>> On the substance of the patch: I wonder whether we could make things
>> more reliable by using git metadata to figure out which .h and .c
>> files to point pgindent at.

> I guess what you're wanting is a test to see if the file is in git or a 
> generated file? That doesn't really arise for me as I always do vpath 
> builds, so generated files are always elsewhere.

Right.  But if we're trying to make this easy, we need to make
the automation work for all three use-cases (in-tree makefiles,
vpath makefiles, meson).  I was just wondering if relying on
git would simplify getting the same results in all three.

			regards, tom lane