Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4MzK-0003LI-9P for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Jun 2022 13:35:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o4MzG-0001vk-QJ for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Jun 2022 13:35:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4MzG-0001vR-HM for pgsql-hackers@lists.postgresql.org; Thu, 23 Jun 2022 13:35:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4Mz7-0001HW-HR for pgsql-hackers@lists.postgresql.org; Thu, 23 Jun 2022 13:35:07 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 25NDYv053922717; Thu, 23 Jun 2022 09:34:57 -0400 From: Tom Lane To: Markus Wanner cc: Peter Eisentraut , exclusion@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: fix crash with Python 3.11 In-reply-to: References: <3375ffd8-d71c-2565-e348-a597d6e739e3@enterprisedb.com> <3890110.1642373624@sss.pgh.pa.us> <73daabb7-9fc7-fb7a-5e06-a968c611b032@enterprisedb.com> <2255118.1643126084@sss.pgh.pa.us> <1103370.1644273481@sss.pgh.pa.us> <1216692.1645644682@sss.pgh.pa.us> <1533956.1645731245@sss.pgh.pa.us> <3027328.1655829211@sss.pgh.pa.us> Comments: In-reply-to Markus Wanner message dated "Thu, 23 Jun 2022 09:41:00 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3922715.1655991297.1@sss.pgh.pa.us> Date: Thu, 23 Jun 2022 09:34:57 -0400 Message-ID: <3922716.1655991297@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Markus Wanner writes: > Actually, the backport of 2e517818f ("Fix SPI's handling of errors") > already broke the API for code using SPICleanup, as that function had > been removed. Granted, it's not documented, but still exported. Under what circumstances would it be OK for outside code to call SPICleanup? regards, tom lane