From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, iwata.aya@fujitsu.com,
        tsunakawa.takay@fujitsu.com, k.jamison@fujitsu.com,
        pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-reply-to: <20210402230355.GA18263@alvherre.pgsql>
References: <20210402230355.GA18263@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 02 Apr 2021 20:03:55 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3928039.1617404844.1@sss.pgh.pa.us>
Date: Fri, 02 Apr 2021 19:07:24 -0400
Message-ID: <3928040.1617404844@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3928040.1617404844%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Apr-02, Tom Lane wrote:
>> +1, but the comment could be more specific.  Maybe like "In regress mode,
>> suppress the length of ErrorResponse and NoticeResponse messages --- the F
>> (file name) field, in particular, can vary in length depending on compiler
>> used."

> With your commit this is no longer true, so how about the attached?

Right.  Your text looks fine.

(I see drongo is now green, so it looks like its compiler does indeed emit
backslash-separated full paths.)

			regards, tom lane