Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7MLI-0002cV-W9 for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Feb 2021 17:53:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l7MLH-0008AX-Rc for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Feb 2021 17:53:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7MLH-0008AQ-Ks for pgsql-hackers@lists.postgresql.org; Wed, 03 Feb 2021 17:53:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7MLF-0003rm-8b for pgsql-hackers@postgresql.org; Wed, 03 Feb 2021 17:53:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 113HrC4c3955613; Wed, 3 Feb 2021 12:53:13 -0500 From: Tom Lane To: Heikki Linnakangas cc: Alvaro Herrera , pgsql-hackers Subject: Re: Removing support for COPY FROM STDIN in protocol version 2 In-reply-to: References: <20210203160958.GA2341@alvherre.pgsql> <3921698.1612369777@sss.pgh.pa.us> Comments: In-reply-to Heikki Linnakangas message dated "Wed, 03 Feb 2021 18:47:05 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3955611.1612374792.1@sss.pgh.pa.us> Date: Wed, 03 Feb 2021 12:53:12 -0500 Message-ID: <3955612.1612374792@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Heikki Linnakangas writes: > Since we're on a removal-spree, it'd also be nice to get rid of the > "fast-path" function call interface, PQfn(). However, libpq is using it > internally in the lo_*() functions, so if we remove it from the server, > lo_*() will stop working with old libpq versions. It would be good to > change those functions now to use PQexecParams() instead, so that we > could remove the fast-path server support in the future. I'm disinclined to touch that. It is considered part of protocol v3, and there is no very good reason to suppose that nothing but libpq is using it. Besides, what would it really save? fastpath.c has not been a source of maintenance problems. regards, tom lane