From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: More weird compiler warnings
In-reply-to: <20230316171846.2yurkzkibrkn566t@awork3.anarazel.de>
References: <144536.1648326206@sss.pgh.pa.us> <20220326205549.mwwlx7cejdght7bf@alap3.anarazel.de> <20230316171846.2yurkzkibrkn566t@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 16 Mar 2023 10:18:46 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3959490.1678991497.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 16 Mar 2023 14:31:37 -0400
Message-ID: <3959491.1678991497@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3959491.1678991497%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-03-26 13:55:49 -0700, Andres Freund wrote:
>> On 2022-03-26 16:23:26 -0400, Tom Lane wrote:
>>> but I'm wondering if we could silence the warning by changing the loop=
 condition to
>>> while (--nb >=3D 0)
>>> which seems like it might be marginally more readable anyway.

>> Yes, that looks like it silences it.  I modified the small reproducer I=
 had in
>> that bug (https://godbolt.org/z/ejK9h6von) and the warning vanishes.

> The recent discussion about warnings reminded me of this. Given the gcc =
bug
> hasn't been fixed, I think we should make that change. I'd vote for
> backpatching it as well - what do you think?

+1, can't hurt anything AFAICS.

			regards, tom lane