From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Importing pg_bsd_indent into our source tree
In-reply-to: <20230209210202.t6n35jaiuw6nl4dk@awork3.anarazel.de>
References: <3935719.1675967430@sss.pgh.pa.us> <20230209210202.t6n35jaiuw6nl4dk@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 09 Feb 2023 13:02:02 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3962627.1675978928.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 09 Feb 2023 16:42:08 -0500
Message-ID: <3962628.1675978928@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3962628.1675978928%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-02-09 13:30:30 -0500, Tom Lane wrote:
>> 0003 lacks meson support (anyone want to help with that?)

> I'll give it a go, unless somebody else wants to.

Thanks.

> Do we expect pg_bsd_indent to build / work on windows, right now?

It would be desirable, for sure.  I've not noticed anything remarkably
unportable in the code, so probably it's just a matter of getting the
build infrastructure to build it.  I suppose that we aren't going to
update the src/tools/msvc scripts anymore, so getting meson to handle
it should be enough??

>> I'd anticipate pushing 0001-0003 shortly but holding 0004 until we are =
ready
>> to do the post-March-CF pgindent run.  (Come to think of it, 0004 had
>> probably better include a pg_bsd_indent version bump too.)

> How large is the diff that creates? If it's not super-widespread, it mig=
ht be
> ok to do that earlier.

It wasn't that big; I posted it in the thread discussing that change.

I think the real issue might just be that, assuming we bump the
pg_bsd_indent version number, that in itself would force interested
committers to update their copy Right Now.  I'd rather give a little
notice.

			regards, tom lane