From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Tristan Partin" <tristan@neon.tech>
cc: "Peter Eisentraut" <peter@eisentraut.org>,
        "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: Make documentation builds reproducible
In-reply-to: <CV0ZWW3XIVPU.1CNCLI07JM8Z@gonk>
References: <9077b779-a9f8-09c8-6e85-da1ebfba15af@eisentraut.org> <CV0ZWW3XIVPU.1CNCLI07JM8Z@gonk>
Comments: In-reply-to "Tristan Partin" <tristan@neon.tech>
	message dated "Thu, 24 Aug 2023 13:44:34 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3966383.1692905406.1@sss.pgh.pa.us>
Date: Thu, 24 Aug 2023 15:30:06 -0400
Message-ID: <3966384.1692905406@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3966384.1692905406%40sss.pgh.pa.us>
Precedence: bulk

"Tristan Partin" <tristan@neon.tech> writes:
> On Wed Aug 23, 2023 at 2:24 PM CDT, Peter Eisentraut wrote:
>> Somewhere at PGCon, I forgot exactly where, maybe in the same meeting 
>> where we talked about getting rid of distprep, we talked about that the 
>> documentation builds are not reproducible (in the sense of 
>> https://reproducible-builds.org/).  This is easily fixable,

> Is there anything I am missing? Is Postgres relying on releases older 
> than snapshot-2018-12-07-01? If so, is it possible to up the minimum 
> version?

AFAICT the "latest stable release" of docbook-xsl is still 1.79.2,
which seems to have been released in 2017, so it's unsurprising that
it's missing this fix.

It's kind of hard to argue that developers (much less distro packagers)
should install unsupported snapshot releases in order to build our docs.
Having said that, maybe we should check whether this patch is compatible
with those snapshot releases, just in case somebody is using one.

			regards, tom lane