From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Importing pg_bsd_indent into our source tree
In-reply-to: <20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de>
References: <3935719.1675967430@sss.pgh.pa.us>
 <20230209210202.t6n35jaiuw6nl4dk@awork3.anarazel.de>
 <20230209215532.oomwhj5jyggmciq7@awork3.anarazel.de>
 <20230209221450.bkuozhhzlgpupx4d@awork3.anarazel.de>
 <3966340.1675981162@sss.pgh.pa.us>
 <20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 09 Feb 2023 15:10:13 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3972583.1675984746.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 09 Feb 2023 18:19:06 -0500
Message-ID: <3972584.1675984746@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3972584.1675984746%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
>> Hmmm .. a shell script would be fine by me, but it won't help in
>> testing a Windows build.  Maybe we need to make it a Perl script?

> At least for casual testing a shell script actually mostly works, due to=
 git
> it's easy enough to have a sh.exe around... Not something I'd necessaril=
y want
> to make a hard dependency, but for something like this it might suffice.=
  Of
> course perl would be more dependable...

Yeah, also less question about whether it works on Windows.
I'll see about moving that into Perl.  It's short enough.

>> BTW, the attachments to your previous message are identical to what
>> I previously posted --- did you attach the wrong set of diffs?

> I attached an extra patch, in addition to yours.

D'oh, I didn't notice that :-(

> I also attached yours so that
> cfbot could continue to work, if you registered this.

I thought about registering it, but that won't teach us anything unless
we make it built-by-default, which was not my intention.  I guess we
could temporarily include it in the build.

			regards, tom lane