Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcua8-0006h3-SH for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Mar 2023 20:52:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pcua7-0001Lj-Pq for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Mar 2023 20:52:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcua7-0001LZ-GX for pgsql-hackers@lists.postgresql.org; Thu, 16 Mar 2023 20:52:15 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcua5-0004f7-5L; Thu, 16 Mar 2023 20:52:15 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 32GKq78P3975825; Thu, 16 Mar 2023 16:52:07 -0400 From: Tom Lane To: Justin Pryzby cc: Robert Treat , Robert Haas , Andrew Dunstan , pgsql-hackers@lists.postgresql.org, David Rowley , Alvaro Herrera Subject: Re: doc: mentioned CREATE+ATTACH PARTITION as an alternative to CREATE TABLE..PARTITION OF In-reply-to: <20230119215832.GH13860@telsasoft.com> References: <20220718143304.GC18011@telsasoft.com> <1e91af94-2bea-5b35-49f3-ea14859c2a0d@dunslane.net> <20220905180403.GN31833@telsasoft.com> <20230119215832.GH13860@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Thu, 19 Jan 2023 15:58:32 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3975823.1678999927.1@sss.pgh.pa.us> Date: Thu, 16 Mar 2023 16:52:07 -0400 Message-ID: <3975824.1678999927@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Thu, Jan 19, 2023 at 04:47:59PM -0500, Robert Treat wrote: >> I think all of that feedback is useful, I guess the immediate question >> becomes if Justin wants to try to proceed with his patch implementing >> the change, or if adjusting the documentation for the current >> implementation is the right move for now. > The docs change is desirable in any case, since it should be > backpatched, and any patch to change CREATE..PARTITION OF would be for > v17+ anyway. Right. Pushed with a little further effort to align it better with surrounding text. regards, tom lane