Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQH9h-0002KU-SY for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Feb 2023 00:20:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pQH9g-0003Xd-Ck for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Feb 2023 00:20:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQH9g-0003XU-3M for pgsql-hackers@lists.postgresql.org; Fri, 10 Feb 2023 00:20:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQH9c-0008J5-CV for pgsql-hackers@lists.postgresql.org; Fri, 10 Feb 2023 00:20:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31A0Kb0A3979958; Thu, 9 Feb 2023 19:20:37 -0500 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org Subject: Re: Importing pg_bsd_indent into our source tree In-reply-to: <20230210000841.4chvtmr4gkrfsotb@awork3.anarazel.de> References: <3935719.1675967430@sss.pgh.pa.us> <20230209210202.t6n35jaiuw6nl4dk@awork3.anarazel.de> <20230209215532.oomwhj5jyggmciq7@awork3.anarazel.de> <20230209221450.bkuozhhzlgpupx4d@awork3.anarazel.de> <3966340.1675981162@sss.pgh.pa.us> <20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de> <3972584.1675984746@sss.pgh.pa.us> <20230210000841.4chvtmr4gkrfsotb@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 09 Feb 2023 16:08:41 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3979956.1675988437.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Feb 2023 19:20:37 -0500 Message-ID: <3979957.1675988437@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2023-02-09 18:19:06 -0500, Tom Lane wrote: >> I thought about registering it, but that won't teach us anything unless >> we make it built-by-default, which was not my intention. I guess we >> could temporarily include it in the build. > The meson patch I sent did build it by default, that's why I saw the win= dows > failure and the freebsd warnings. If we don't want that, we'd need to ad= d > build_by_default: false > I'm fine either way. It's barely noticeable compared to the rest of post= gres. Yeah, build-by-default isn't really a big deal. Install-by-default is more of a problem... regards, tom lane