From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
cc: Euler Taveira <euler@eulerto.com>,
    pgsql-hackers@lists.postgresql.org
Subject: Re: Unexpected changes of CurrentResourceOwner and
 CurrentMemoryContext
In-reply-to: <202509121703.y7nfmqwotmfv@alvherre.pgsql>
References: <202509121703.y7nfmqwotmfv@alvherre.pgsql>
Comments: In-reply-to =?us-ascii?Q?=3D=3Futf-8=3FQ=3F=3DC3=3D81lvaro=3F=3D?=
 Herrera <alvherre@kurilemu.de>
   message dated "Fri, 12 Sep 2025 19:10:55 +0200."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Fri, 12 Sep 2025 20:03:36 +0200
Message-ID: <39892.1757700216@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/39892.1757700216%40localhost>
Precedence: bulk

=C3=81lvaro Herrera <alvherre@kurilemu.de> wrote:

> On 2025-Sep-12, Antonin Houska wrote:
>=20
> > Euler Taveira <euler@eulerto.com> wrote:
> >=20
> > > Interesting. I'm wondering that if this patch is applied we could rem=
ove the
> > > following code [...] from pg_logical_slot_get_changes_guts and
> > > LogicalSlotAdvanceAndCheckSnapState functions too. IIUC the referred
> > > code is a band-aid that will be improved someday.
> >=20
> > Even though we're fixing the likely reason of this problem, we cannot b=
e 100%
> > sure that no other problem like this still exists. So I'd not remove th=
is
> > assignment. Maybe add Assert(CurrentResourceOwner =3D=3D old_resowner) =
in front of
> > that, and adjust the comment?
>=20
> Yeah, I'm going to risk removing it, because if we don't do it now,
> we're never going to do it.  We can mitigate the risk of missing
> remaining bugs by having that assertion you suggest, so that if anyone
> actually hits a problem here, we'll know soon enough.
>=20
> I have pushed it with that change.  I'll also add an open item for pg19
> so that we remember to come back to remove the assertions, if we feel we
> no longer need them.

I was worried about removing those workarounds because it was not trivial to
diagnose the issue. But it should be ok for the master branch. Thanks.

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com