Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uYoHb-00C1z7-Cj
	for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jul 2025 16:01:31 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uYoHY-003ZT7-Sm
	for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jul 2025 16:01:29 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uYoHY-003ZRI-Id
	for pgsql-hackers@lists.postgresql.org; Mon, 07 Jul 2025 16:01:29 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uYoHW-006G2L-14
	for pgsql-hackers@postgresql.org;
	Mon, 07 Jul 2025 16:01:28 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 567G1JjJ399301;
	Mon, 7 Jul 2025 12:01:19 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Michael Paquier <michael@paquier.xyz>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: C11 / VS 2019
In-reply-to: <04ab76a3-186c-4a37-8076-e6882ebf9d43@eisentraut.org>
References: <01a69441-af54-4822-891b-ca28e05b215a@eisentraut.org>
 <aD2sgK4tMVumNxt4@nathan> <aD5_OiEKEz2RpYFR@paquier.xyz>
 <b4af1f32-f90f-4670-9598-029e99b69f31@eisentraut.org>
 <e5488fe3-38d5-4b1f-ae0d-a254dc969f16@eisentraut.org>
 <90506.1751754464@sss.pgh.pa.us>
 <46154df9-f514-4d79-89bb-df4af46b1b9f@eisentraut.org>
 <CAN55FZ03ZXUFsxiyR0hzFsrYG-jbQzt8=uoC8b16THu3kU92fg@mail.gmail.com>
 <387476.1751897627@sss.pgh.pa.us>
 <04ab76a3-186c-4a37-8076-e6882ebf9d43@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Mon, 07 Jul 2025 17:08:27 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <399299.1751904079.1@sss.pgh.pa.us>
Date: Mon, 07 Jul 2025 12:01:19 -0400
Message-ID: <399300.1751904079@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/399300.1751904079%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 07.07.25 16:13, Tom Lane wrote:
>> Huh.  Can we trawl the release notes for VS and see if this was
>> acknowledged as a bug fix, and if so when did it happen?

> But this one [0] seems to indicate you might need at least 16.5 for this.

Ah, that says

    Starting in Visual Studio 2019 version 16.5, preprocessor support
    for the C++20 standard is feature-complete. These changes are
    available by using the /Zc:preprocessor compiler switch.

The reference to C++20 is a bit confusing in this context; does C++
really have a different preprocessor?  But anyway, the support matrix
seems like a convincing argument that we don't have to support 16.3.
If Andrew is willing to update drongo, I'm content to leave it at
that.

			regards, tom lane