Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmRXe-0002s2-56 for pgsql-hackers@arkaria.postgresql.org; Sat, 20 Jun 2020 00:39:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jmRXb-0004Cw-S9 for pgsql-hackers@arkaria.postgresql.org; Sat, 20 Jun 2020 00:39:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmRXb-00048q-Kp for pgsql-hackers@lists.postgresql.org; Sat, 20 Jun 2020 00:39:27 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmRXT-0002Wq-A5 for pgsql-hackers@postgresql.org; Sat, 20 Jun 2020 00:39:26 +0000 Received: from hnk.local (p2604028-ipngn12401funabasi.chiba.ocn.ne.jp [180.1.110.28]) by oss.nttdata.com (Postfix) with ESMTPSA id 61FB660321; Sat, 20 Jun 2020 09:39:13 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: min_safe_lsn column in pg_replication_slots view To: Michael Paquier Cc: Kyotaro Horiguchi , amit.kapila16@gmail.com, pgsql-hackers@postgresql.org, alvherre@2ndquadrant.com References: <20200619013958.GC453547@paquier.xyz> <3b016893-9638-4f99-a1d0-bce007e8242a@oss.nttdata.com> <20200619073609.GF453547@paquier.xyz> <20200619.164304.392203744101291087.horikyota.ntt@gmail.com> <81f74732-fca5-4f4b-1f52-645f84a8d9fa@oss.nttdata.com> <20200619121552.GH453547@paquier.xyz> From: Fujii Masao Message-ID: <399663b9-5fce-b41e-07e1-d9531af73a6c@oss.nttdata.com> Date: Sat, 20 Jun 2020 09:39:13 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200619121552.GH453547@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/06/19 21:15, Michael Paquier wrote: > On Fri, Jun 19, 2020 at 05:34:01PM +0900, Fujii Masao wrote: >> On 2020/06/19 16:43, Kyotaro Horiguchi wrote: >>> At Fri, 19 Jun 2020 16:36:09 +0900, Michael Paquier wrote in >>>> So we usually avoid to do that between betas, but my take here is that >>>> a catalog bump is better than regretting a change we may have to live >>>> with after the release is sealed. >> >> Sounds reasonable. > > If we want to make this happen, I am afraid that the time is short as > beta2 is planned for next week. As the version will be likely tagged > by Monday US time, it would be good to get this addressed within 48 > hours to give some room to the buildfarm to react. Attached is a > straight-forward proposal of patch. Any thoughts? It's better if we can do that. But I think that we should hear Alvaro's opinion about this before rushing to push the patch. Even if we miss beta2 as the result of that, I'm ok. We would be able to push something better into beta3. So, CC Alvaro. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION