Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
References: <cb0bfbb9-a3bb-c43a-73bd-651e801193f2@dunslane.net>
 <YKHNLQlZYMxL7wBO@paquier.xyz>
 <e3d251fc-b3b1-d254-2b4f-70a6dcce5b29@dunslane.net>
 <YKMcbKePfS6BHKXz@paquier.xyz> <YKX8vOWo9iov7BJw@paquier.xyz>
 <YVaohuWPb3oDl4nn@paquier.xyz>
 <b8293b8c-2814-723c-5fdb-4496f3983cf8@dunslane.net>
 <3715954.1633208613@sss.pgh.pa.us>
 <0f70fc0f-c51a-7a58-7e12-c702352eb076@dunslane.net>
 <3735235.1633232078@sss.pgh.pa.us> <YVlV30Z1gzmFfdCk@paquier.xyz>
 <4f54cd76-756e-ba8e-0238-cacf6dbc971b@enterprisedb.com>
From: Andrew Dunstan <andrew@dunslane.net>
Message-ID: <39d5c0ab-43c8-b7a3-adb6-d252fafad7b4@dunslane.net>
Date: Mon, 11 Oct 2021 09:04:47 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <4f54cd76-756e-ba8e-0238-cacf6dbc971b@enterprisedb.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/39d5c0ab-43c8-b7a3-adb6-d252fafad7b4%40dunslane.net>
Precedence: bulk


On 10/10/21 10:07 AM, Peter Eisentraut wrote:
> On 03.10.21 09:03, Michael Paquier wrote:
>> On Sat, Oct 02, 2021 at 11:34:38PM -0400, Tom Lane wrote:
>>> Maybe we could leave test.sh in place for awhile?  I'd rather
>>> not cause a flag day for buildfarm owners.  (Also, how do we
>>> see this working in the back branches?)
>>
>> I would be fine with test.sh staying around for now.
>
> test.sh could be changed to invoke the TAP test.


Keeping test.sh is not necessary - I mis-remembered what the test module
does.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com