Feedback-ID: i7c334307:Fastmail
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\))
Subject: Re: RFC: Additional Directory for Extensions
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <DA13F479-6587-4841-AD53-F3D08BBBA08B@justatheory.com>
Date: Mon, 18 Nov 2024 14:19:07 -0500
Cc: Craig Ringer <craig.ringer@enterprisedb.com>,
 Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3AA66D08-D3C1-409E-A120-721ACF923EC6@justatheory.com>
References: <CA+TgmoaMk==vOUmWwJ5ZA-EueNqa9RQaWMEiHCF1ZKW_YCcj8g@mail.gmail.com>
 <202406251012.brdp2dobkf7n@alvherre.pgsql>
 <CA+TgmoYcAmhnSUHKdJsS1wOR-9+y6dbLhfJ3Ad+iZEDmA1mPXg@mail.gmail.com>
 <FE1622BC-81BB-487B-BF0A-4D29906F8F47@justatheory.com>
 <C0393253-B71B-4AF9-87DA-A831AC8B3836@justatheory.com>
 <CA+VUV5oWkMVvtNB0BG2CM8SrmOkeW6fEtXGehbniHqR9MhMzVw@mail.gmail.com>
 <CAGRY4nxP6A5Dz23g+aGD-agdVwUj_qrG6szd-mWc0E5OFMBg4w@mail.gmail.com>
 <B86AF59F-5B65-4CC9-91A4-B79A089C2876@justatheory.com>
 <CAGRY4ny=Oy-F0qCRFQa=XtEqyUbMygvbqqKahAvbae7v4LTOrQ@mail.gmail.com>
 <AF4A50CD-C5CF-406D-9700-1B889F40E8FB@justatheory.com>
 <CAGRY4nx8Fmea4udk--PKdvfgpNdqC+rcueAmGwuw2PD9dv+zqQ@mail.gmail.com>
 <D30A91FA-A6D4-4737-941F-0BBB2984B730@justatheory.com>
 <0d384836-7e6e-4932-af3b-8dad1f6fee43@eisentraut.org>
 <0D89C6B2-F294-4389-9DDA-07C381995292@justatheory.com>
 <04235387-120e-4bf6-b5c8-645d869222b9@eisentraut.org>
 <DA13F479-6587-4841-AD53-F3D08BBBA08B@justatheory.com>
To: Peter Eisentraut <peter@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/3AA66D08-D3C1-409E-A120-721ACF923EC6%40justatheory.com>
Precedence: bulk

Hi Peter,

Making another pass at this proposal, I=E2=80=99m a bit confused by this =
issue:

On Nov 12, 2024, at 09:44, David E. Wheeler <david@justatheory.com> =
wrote:

>>>> - The biggest problem is that many extensions set in their control =
file
>>>>=20
>>>>   module_pathname =3D '$libdir/foo'
>>>>=20
>>>> This disables the use of dynamic_library_path, so this whole idea =
of installing an extension elsewhere won't work that way.  The obvious =
solution is that extensions change this to just 'foo'.  But this will =
require a lot updating work for many extensions, or a lot of patching by =
packagers.
>=20
> Yeah, '$libdir/foo' has been the documented way to do it for quite =
some time, as I recall. Perhaps the behavior of the MODULE_PATHNAME =
replacement function could be changed to omit $libdir when writing the =
SQL files?

Elsewhere you write:

> Nothing changes about shared library files.  They are looked up in =
dynamic_library_path or any hardcoded file name.

And also point out that the way to install them is:

```
make install datadir=3D/else/where/share pkglibdir=3D/else/where/lib
```

So as long as dynamic_library_path includes /else/where/lib it should =
work, just as before, no?

Best,

David