Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0hc3-007G1A-Bf for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Nov 2023 12:24:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r0hc2-0035fy-30 for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Nov 2023 12:24:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0hc1-0035fn-Pw for pgsql-hackers@lists.postgresql.org; Wed, 08 Nov 2023 12:24:49 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0hbz-004YtU-8f for pgsql-hackers@postgresql.org; Wed, 08 Nov 2023 12:24:48 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 10BA02FC603F for ; Wed, 8 Nov 2023 13:24:42 +0100 (CET) Received: from s980.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 010A02E27614; Wed, 8 Nov 2023 13:24:42 +0100 (CET) Received: from s472.loopia.se (unknown [172.22.191.6]) by s980.loopia.se (Postfix) with ESMTP id F2DC622016D5; Wed, 8 Nov 2023 13:24:41 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.01 X-Spam-Level: X-Spam-Status: No, score=-1.01 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=disabled Received: from s979.loopia.se ([172.22.191.6]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with UTF8LMTP id 2R36K5QC9UFy; Wed, 8 Nov 2023 13:24:41 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s979.loopia.se (Postfix) with ESMTPSA id 5741210BC403; Wed, 8 Nov 2023 13:24:41 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: pgsql: Clean up role created in new subscription test. From: Daniel Gustafsson In-Reply-To: <202311081142.znnn3kgehvqo@alvherre.pgsql> Date: Wed, 8 Nov 2023 13:24:41 +0100 Cc: Peter Eisentraut , Tom Lane , Robert Haas , PostgreSQL Hackers Content-Transfer-Encoding: 7bit Message-Id: <3B08E3F2-37C8-4D26-BA80-C4C0F4DF3848@yesql.se> References: <202311081142.znnn3kgehvqo@alvherre.pgsql> To: Alvaro Herrera X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 8 Nov 2023, at 12:42, Alvaro Herrera wrote: > On 2023-Nov-08, Peter Eisentraut wrote: >> I think the earlier idea of just counting roles, tablespaces, etc. before >> and after would be sufficient. > > Maybe record global objects in a permanent table in test_setup.sql Since test_setup.sql is part of the regress schedule and not pg_regress we would have to implement this for each test run (regress, contribs etc), which is what Peter didn't like about the original suggestion. -- Daniel Gustafsson