Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVhAh-00082b-70 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Oct 2020 20:26:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kVhAe-0006SL-J4 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Oct 2020 20:26:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVhAe-0006Ng-7N for pgsql-hackers@lists.postgresql.org; Thu, 22 Oct 2020 20:26:48 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kVhAb-0006Me-9F for pgsql-hackers@postgresql.org; Thu, 22 Oct 2020 20:26:46 +0000 Received: by mail-pl1-x642.google.com with SMTP id v22so1561044ply.12 for ; Thu, 22 Oct 2020 13:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6KIwiRdnZbQdxeWu/Ra/oW7YoSFB6/6jRa97s9D9IcU=; b=U/hw0/Y8dDggQrvCEQbLKWQ7CgDTNo7d1xKTGUJKF8tqt/McMfwnN8OIza+u/Vkzc5 54wrfGJaZMRW/ou4Wy2B8ZmikzTz7Big+AYkuEnqgh7mplyYHffTDuVqUPgZHtfPfyQ/ 0Ubc93ESKMRfFm3jQIrlvGtpYjQwagiXWVLq5iI0mYcoiBKKid0XMzPh7RiUxQszwasJ TbAqKuUEtxqIMjjeEzc43WVeWpVimXGce/qvcYf2ljjPXu/iSp24974SdtwQrEu1tRlM PJibnsezYXIm3BYInzDE2kTpNwQM4smVRknPrcUyD9JRGYSty/rC0dMl/XCJjwMswt4k ulFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6KIwiRdnZbQdxeWu/Ra/oW7YoSFB6/6jRa97s9D9IcU=; b=S5XX9xk2Tq4mFKoXeT+ejsOouokX8Zy2RPb55mEu4409uMfi7QjBwDkYIIv5uc34+0 qXs/p/sh9ysBWnLjnQhfuNksxlxonTRhJF/DX/e1rUx94FbvEum/SPKtXfefKLUvujbP sCpLQgCn4A0m+XY5Ae+VngohVQqmleKGl3SDrLwPwU/7SvyTqtM9MpOIeP/n6QzZIzKF xP/3n0TNEQ3JtoyWVmWMZ3+roNDO0299VqiLDjAHnktejnOj2+Hl3jPSi8vvvKbcWiaS RzZxC+snmS/9uty8BMt0uXjNP4lszxV+DJyzOT5oeub083d3B1GgnywGMcBmaY5m9OXm QBsA== X-Gm-Message-State: AOAM530EKSrKhK0Lzi5UI0tzBQcK0ZkHH0hyl8AtqEtjSsj01LnBbfMP 2THkC0UB/DTpB3d9Gc+xb//kPYUUQfQNptQYVejsLIJUrOz7lgO4lVuXgzChspReA9A8pQwQjDQ KABSOoIwK6bjLOSY7VhGMxdTSNJ9to9PuEx9zaYa1XVrv36NsMYPDSP45ZRzlmcQ6zuok1gf0hu 2Wjm7BHpITEK5o7VK1qQ77yX2cPJZdyE1etCLe X-Google-Smtp-Source: ABdhPJw7j3QJTjfceFZEz2CB3ppiBm7I3BaeHrYnbVOExR1AO8Q6Z3WNxq7LmY18oJaHIKjO4n0T6A== X-Received: by 2002:a17:902:8bc6:b029:d3:d1ff:91b6 with SMTP id r6-20020a1709028bc6b02900d3d1ff91b6mr3905032plo.30.1603398403697; Thu, 22 Oct 2020 13:26:43 -0700 (PDT) Received: from [192.168.0.29] (24-113-193-150.wavecable.com. [24.113.193.150]) by smtp.gmail.com with ESMTPSA id 194sm3282143pfz.182.2020.10.22.13.26.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2020 13:26:42 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: new heapcheck contrib module From: Mark Dilger In-Reply-To: <40724.1603397356@sss.pgh.pa.us> Date: Thu, 22 Oct 2020 13:26:41 -0700 Cc: Robert Haas , Peter Geoghegan , "Andrey M. Borodin" , Stephen Frost , Michael Paquier , Amul Sul , Dilip Kumar , Andres Freund , PostgreSQL-development Content-Transfer-Encoding: quoted-printable Message-Id: <3CF77684-FA8D-4D63-AD95-DC4C9A2537E3@enterprisedb.com> References: <12ED3DA8-25F0-4B68-937D-D907CFBF08E7@enterprisedb.com> <20200420194210.sevnpi4lyghoanxi@alap3.anarazel.de> <23E60C3C-C20A-4508-84AC-E0CEA59E784A@enterprisedb.com> <5F743835-3399-419C-8324-2D424237E999@enterprisedb.com> <885D2EC9-7D06-4903-A17D-72C184A1E1C5@enterprisedb.com> <5CC85F28-F210-47AC-8DA8-EC4E82AF3FD5@enterprisedb.com> <0C0349EB-DD85-4DA8-82C7-DF70AB714592@enterprisedb.com> <9DF93B83-FE46-4EC4-A99D-77A60729FD2D@enterprisedb.com> <50F6468F-5A5E-412A-86EC-DF24B549D733@enterprisedb.com> <7D603B53-8078-4AF0-851B-803FF4416501@enterprisedb.com> <98265AA9-7BDC-4708-9348-CC1B173BBE1D@enterprisedb.com> <209783.1603313248@sss.pgh.pa.us> <77A60E99-6054-40FD-A5D6-769C287D4A0F@enterprisedb.com> <721BFA83-EA6F-463D-A9DF-CE78A318B73A@enterprisedb.com> <2A7DA1A8-C4AA-43DF-A985-3CA52F4DC775@enterprisedb.com> <40724.1603397356@sss.pgh.pa.us> To: Tom Lane X-Mailer: Apple Mail (2.3608.120.23.2.1) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > On Oct 22, 2020, at 1:09 PM, Tom Lane wrote: >=20 > ooh, looks like prairiedog sees the problem too. That means I should = be > able to reproduce it under a debugger, if you're not certain yet where > the problem lies. Thanks, Tom, but I question whether the regression test failures are = from a problem in the verify_heapam.c code. I think they are a busted = perl test. The test was supposed to corrupt the heap by overwriting a = heap file with a large chunk of garbage, but in fact only wrote a small = amount of garbage. The idea was to write about 2000 bytes starting at = offset 32 in the page, in order to corrupt the line pointers, but owing = to my incorrect use of syswrite in the perl test, that didn't happen. I think the uninitialized variable warning is warning about a real = problem in the c-code, but I have no reason to think that particular = problem is causing this particular regression test failure. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company