Message-ID: <3D986E28.60404@joeconway.com>
Date: Mon, 30 Sep 2002 08:30:48 -0700
From: Joe Conway <mail@joeconway.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.1) Gecko/20020826
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Sullivan <andrew@libertyrms.info>,
	pgsql-hackers@postgresql.org
Subject: Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
References: <8183.1033166430@sss.pgh.pa.us>
	<200209280030.g8S0UcR16258@candle.pha.pa.us>
	<20020930103138.C1405@mail.libertyrms.com>
	<21492.1033399107@sss.pgh.pa.us>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> One thing I am undecided about: I am more than half tempted to put in
> the fix that makes us able to cope with mktime's broken-before-1970
> behavior in recent glibc versions (e.g., Red Hat 7.3).  This seems like
> a good idea considering that other Linux distros will surely be updating
> glibc soon too.  On the other hand, it's hard to call it a critical bug
> fix --- it ain't on a par with the vacuum/clog problem, for sure.  And
> the patch has received only limited testing (basically just whatever
> use 7.3beta1 has had).  On the third hand, the patch only does something
> if mktime() has already failed, so it's hard to see how it could make
> life worse even if it's buggy.
> 
> Any votes on whether to fix that or leave it alone in 7.2.3?  I need
> some input in the next few hours ...
> 

+1 for fixing it

Joe