Feedback-ID: i675e48f3:Fastmail
Date: Fri, 3 Oct 2025 08:13:44 -0400
From: Greg Burd <greg@burd.me>
To: Daniel Gustafsson <daniel@yesql.se>, David Rowley
 <dgrowleyml@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Message-ID: <3E15C43D-8FDB-454F-A3E3-182210680C58@getmailspring.com>
In-Reply-To: <197CAFC2-963B-4414-9A51-08AF648146E4@yesql.se>
References: <197CAFC2-963B-4414-9A51-08AF648146E4@yesql.se>
Subject: Re: [PATCH] Add tests for Bitmapset
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/3E15C43D-8FDB-454F-A3E3-182210680C58%40getmailspring.com>
Precedence: bulk


On Oct 3 2025, at 4:25 am, Daniel Gustafsson <daniel@yesql.se> wrote:

>> On 3 Oct 2025, at 01:36, David Rowley <dgrowleyml@gmail.com> wrote:
>> 
>> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel@yesql.se> wrote:
>>> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
>>> since that is a STRICT function, making the test for NULL
>>> superfluous code:
>> 
>> I see test_random_operations() is also strict. Is it worth getting rid
>> of the SQL NULL checks on the inputs there too? Aka, the attached.
> 
> Indeed, but reading the code I wonder if STRICT was a mistake and the intention
> was to allow NULL input?

Yes, it was an oversight after I re-worked the random function.

> That being said, the function is never called with
> NULL so that's mostly academic thinking.  +1 for removing the NULL
> checks and simplifying the code.

I agree, and thank you both for the attention to detail and interest in
this test suite.

> 
> --
> Daniel Gustafsson

best.

-greg