Message-ID: <3EA92A29.3070708@mohawksoft.com>
Date: Fri, 25 Apr 2003 08:29:29 -0400
From: mlw <pgsql@mohawksoft.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.0.2) Gecko/20030208 Netscape/7.02
MIME-Version: 1.0
To: Bruce Momjian <pgman@candle.pha.pa.us>,
	pgsql-hackers@postgresql.org
Subject: Re: close() vs. closesocket()
References: <200304241835.h3OIZ2s04294@candle.pha.pa.us>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

In porting to Windows, I would create a new source file called pgsocket, 
or something, and implement *all* the socket cruft there. Where ever you 
mess with a socket, i.e. send, recv,  poll,  accept, listen, 
get/setsockopt, select, etc. make it a function. Furthermore, try to 
bring some of the logical cruft that goes along with sockets and bring 
it into the module, i.e. don't call select(...) then call recv, call 
SocketSelectRead(...).

Windows' sockets aren't very good. They will be good enough to be 
functional, but eventually, someone will want to rewrite with completion 
ports.


Bruce Momjian wrote:

>Looking at libpq, you can see Win32 requires closesocket() while Unix
>uses just uses close().
>
>I have to add this type of change to the backend for Win32, so I am
>inclined to make all the socket close calls closesocket() and #define
>that as close() on Unix?  It would remove quite a few Win32 defs from
>libpq too.
>
>Comments?
>
>  
>