Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: remove obsolete comment in AtEOXact_Inval
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <9ED67E9F-9735-4033-AF27-31A674DE75C8@gmail.com>
Date: Fri, 8 May 2026 10:54:22 +0200
Cc: Steven Niu <niushiji@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3F5432E3-7E1D-4B18-B745-0B6FFC3EA37F@yesql.se>
References: 
 <MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com>
 <9ED67E9F-9735-4033-AF27-31A674DE75C8@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/3F5432E3-7E1D-4B18-B745-0B6FFC3EA37F%40yesql.se>
Precedence: bulk

> On 27 Oct 2025, at 04:50, Chao Li <li.evan.chao@gmail.com> wrote:
>=20
>> On Oct 27, 2025, at 10:43, Steven Niu <niushiji@gmail.com> wrote:
>>=20
>> Hi, Hackers,
>>=20
>> When I read the code, I noticed there is one line of comment in =
function AtEOXact_Inval() which is obviously obsolete.
>>=20
>>    "This should be called as the last step in processing a =
transaction" =20
>>=20
>> Steven<0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch>
>=20
> +1
>=20
> The comment of "void AtEOXact_Inval(bool isCommit):
> ```
> * Note:
> * This should be called as the last step in processing a transaction.
> ```
> Was added 29 years ago.

This comment was part of the Postgres95 import, and was originally added =
to the
function RegisterInvalid() which in turn was committed by Cimarron =
Taylor in
1990.  I agree that it's no longer helpful and will go ahead to remove =
it shortly
unless someone disagrees.

--
Daniel Gustafsson