Message-ID: <3F78D469.6000205@Yahoo.com>
Date: Mon, 29 Sep 2003 20:55:05 -0400
From: Jan Wieck <JanWieck@Yahoo.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.4) Gecko/20030624
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christopher Kings-Lynne <chriskl@familyhealth.com.au>,
	Bruce Momjian <pgman@candle.pha.pa.us>,
	Stephan Szabo <sszabo@megazone.bigpanda.com>,
	Peter Childs <Blue.Dragon@blueyonder.co.uk>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ADD FOREIGN KEY (was Re: [GENERAL] 7.4Beta)
References: <200309281940.h8SJe3O01852@candle.pha.pa.us>
	<3F77ABA0.4070600@familyhealth.com.au>
	<16699.1064809727@sss.pgh.pa.us> <3F78D0E5.7050805@Yahoo.com>
	<13819.1064882905@sss.pgh.pa.us>
In-Reply-To: <13819.1064882905@sss.pgh.pa.us>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit


Tom Lane wrote:

> Jan Wieck <JanWieck@Yahoo.com> writes:
>> I think I can accept it to be the choice of the DBA what to do. Pg_dump 
>> has that kind of options already, one can choose between COPY and INSERT 
>> for example. Why not adding the choice of dumping FKeys as ALTER TABLE 
>> or CREATE CONSTRAINT TRIGGER?
> 
> We don't want it dumping as CREATE CONSTRAINT TRIGGER, because (a) that
> loses pg_depend information and (b) it's too low-level a representation;
> we couldn't ever change the implementation of foreign keys as long as
> dumps look like that.

That's finally 2 points, okay.

> 
> Also, I don't see why you'd want to make such a choice at pg_dump time.
> Probably better to control it at restore time.  Accordingly, my proposal
> if we were to go that route would be a boolean GUC variable that simply
> prevents ALTER TABLE ADD FOREIGN KEY from doing the validity checks.

Okay too. And this would be simple and safe enough to add it at the time 
being.


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #